Skip to content

Commit 44e5100

Browse files
committedMar 8, 2025
move winresources into cmd/docker
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent 2eec746 commit 44e5100

11 files changed

+17
-17
lines changed
 

‎.dockerignore

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/build/
2-
/cli/winresources/versioninfo.json
3-
/cli/winresources/*.syso
2+
/cmd/docker/winresources/versioninfo.json
3+
/cmd/docker/winresources/*.syso
44
/man/man*/
55
/man/vendor/
66
/man/go.sum

‎.gitignore

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
Thumbs.db
99
.editorconfig
1010
/build/
11-
/cli/winresources/versioninfo.json
12-
/cli/winresources/*.syso
11+
/cmd/docker/winresources/versioninfo.json
12+
/cmd/docker/winresources/*.syso
1313
profile.out
1414

1515
# top-level go.mod is not meant to be checked in

‎Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ ARG PACKAGER_NAME
6767
COPY --link --from=goversioninfo /out/goversioninfo /usr/bin/goversioninfo
6868
RUN --mount=type=bind,target=.,ro \
6969
--mount=type=cache,target=/root/.cache \
70-
--mount=type=tmpfs,target=cli/winresources \
70+
--mount=type=tmpfs,target=cmd/docker/winresources \
7171
# override the default behavior of go with xx-go
7272
xx-go --wrap && \
7373
# export GOCACHE=$(go env GOCACHE)/$(xx-info)$([ -f /etc/alpine-release ] && echo "alpine") && \

‎cmd/docker/docker_windows_386.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
//go:build windows && 386
22

3-
//go:generate goversioninfo -o=../../cli/winresources/resource.syso -icon=winresources/docker.ico -manifest=winresources/docker.exe.manifest ../../cli/winresources/versioninfo.json
3+
//go:generate goversioninfo -o=./winresources/resource.syso -icon=internal/assets/docker.ico -manifest=internal/assets/docker.exe.manifest ./winresources/versioninfo.json
44

55
package main
66

7-
import _ "github.com/docker/cli/cli/winresources"
7+
import _ "github.com/docker/cli/cmd/docker/winresources"

‎cmd/docker/docker_windows_amd64.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
//go:build windows && amd64
22

3-
//go:generate goversioninfo -64=true -o=../../cli/winresources/resource.syso -icon=winresources/docker.ico -manifest=winresources/docker.exe.manifest ../../cli/winresources/versioninfo.json
3+
//go:generate goversioninfo -64=true -o=./winresources/resource.syso -icon=internal/assets/docker.ico -manifest=internal/assets/docker.exe.manifest ./winresources/versioninfo.json
44

55
package main
66

7-
import _ "github.com/docker/cli/cli/winresources"
7+
import _ "github.com/docker/cli/cmd/docker/winresources"

‎cmd/docker/docker_windows_arm.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
//go:build windows && arm
22

3-
//go:generate goversioninfo -arm=true -o=../../cli/winresources/resource.syso -icon=winresources/docker.ico -manifest=winresources/docker.exe.manifest ../../cli/winresources/versioninfo.json
3+
//go:generate goversioninfo -arm=true -o=./winresources/resource.syso -icon=internal/assets/docker.ico -manifest=internal/assets/docker.exe.manifest ./winresources/versioninfo.json
44

55
package main
66

7-
import _ "github.com/docker/cli/cli/winresources"
7+
import _ "github.com/docker/cli/cmd/docker/winresources"

‎cmd/docker/docker_windows_arm64.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
//go:build windows && arm64
22

3-
//go:generate goversioninfo -arm=true -64=true -o=../../cli/winresources/resource.syso -icon=winresources/docker.ico -manifest=winresources/docker.exe.manifest ../../cli/winresources/versioninfo.json
3+
//go:generate goversioninfo -arm=true -64=true -o=./winresources/resource.syso -icon=internal/assets/docker.ico -manifest=internal/assets/docker.exe.manifest ./winresources/versioninfo.json
44

55
package main
66

7-
import _ "github.com/docker/cli/cli/winresources"
7+
import _ "github.com/docker/cli/cmd/docker/winresources"

‎scripts/build/mkversioninfo

+4-4
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ VERSION_QUAD=$(printf "%s" "$VERSION" | sed -re 's/^([0-9.]*).*$/\1/' | sed -re
2121
# Microsoft Windows Version Information and an icon using goversioninfo.
2222
# https://docs.microsoft.com/en-us/windows/win32/menurc/stringfileinfo-block
2323
# https://github.com/josephspurrier/goversioninfo/blob/master/testdata/resource/versioninfo.json
24-
cat > ./cli/winresources/versioninfo.json <<EOL
24+
cat > ./cmd/docker/winresources/versioninfo.json <<EOL
2525
{
2626
"FixedFileInfo":
2727
{
@@ -61,9 +61,9 @@ cat > ./cli/winresources/versioninfo.json <<EOL
6161
}
6262
}
6363
EOL
64-
(set -x ; cat ./cli/winresources/versioninfo.json)
64+
(set -x ; cat ./cmd/docker/winresources/versioninfo.json)
6565

6666
# Create winresources package stub if removed while using tmpfs in Dockerfile
67-
if [ ! -f "./cli/winresources/winresources.go" ]; then
68-
echo "package winresources" > "./cli/winresources/winresources.go"
67+
if [ ! -f "./cmd/docker/winresources/winresources.go" ]; then
68+
echo "package winresources" > "./cmd/docker/winresources/winresources.go"
6969
fi

0 commit comments

Comments
 (0)