Google Git
Sign in
chromium / chromium / src / 0a43dab51957c8f1670d228d93fde64ec93120d9
commit0a43dab51957c8f1670d228d93fde64ec93120d9[log] [tgz]
authorJames Cook <[email protected]>Wed Oct 16 08:27:01 2019
committerCommit Bot <[email protected]>Wed Oct 16 08:27:01 2019
tree3a0c23baf97fd20a6885ad78e78fedbf7a23128b
parent2dec16b36fb0a928039ce93c2ef790978c86ed4c [diff]
sync: Add new model types for OS_PREFERENCES and OS_PRIORITY_PREFERENCES

Add the new syncer::ModelType entries for Chrome OS system preference
sync. These follow the existing convention of not being wrapped in
platform ifdefs.

Add support to PrefServiceSyncable for registering prefs in the new
categories. The new registration flags are wrapped in ifdefs, since
it doesn't make sense for non-Chrome OS platforms to register
Chrome OS system prefs.

Add a base::Feature SplitSettingsSync to control whether the new
model types are actually used for syncing. This must stay disabled
until the server-side protobufs have been deployed to production.

Add unit tests for PrefServiceSyncable for the new categories.

There are no user visible changes.

A design doc is linked from the bug.

Bug: 1013466
Test: added to components_unittests
Change-Id: Ice645292353c91dbd6c27a305bed95bd99ed9ec0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859884
Auto-Submit: James Cook <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Reviewed-by: ssid <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Dominic Battré <[email protected]>
Cr-Commit-Position: refs/heads/master@{#706352}
28 files changed
tree: 3a0c23baf97fd20a6885ad78e78fedbf7a23128b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. .vpython3
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .