Google Git
Sign in
chromium / chromium / src / 7177b371e67997d32640c9bceccfcb1094e78a1e
commit7177b371e67997d32640c9bceccfcb1094e78a1e[log] [tgz]
authorVictor Hugo Vianna Silva <[email protected]>Tue Dec 12 10:36:19 2023
committerChromium LUCI CQ <[email protected]>Tue Dec 12 10:36:19 2023
tree13f2b80de92fb22c61cef1901cb02f7f62007735
parent784a9936eed70f994d756464b6f43390ecf66cab [diff]
Split WEBAUTHN_CREDENTIAL and PASSWORDS ModelTypeControllers

No observable behavior change.
The controllers were originally merged in crrev.com/c/4517941 so
WEBAUTHN_CREDENTIAL would honor the PASSWORDS account storage opt-in.
With crrev.com/c/4874142, this is now guaranteed by
UserSelectableType::kPasswords mapping to both data types. So the
controllers can be split again.
https://source.chromium.org/chromium/chromium/src/+/main:components/sync/base/user_selectable_type.cc;l=63;drc=aec2b547f897594236bef8285c629fbafa61c4d6

Let's look at what other logic is currently being shared by 2 types:

1. Wiping of account storage settings:

Only needs to happen once, it can live in the PASSWORDS controller.
It's also going away soon-ish.
https://source.chromium.org/chromium/chromium/src/+/main:components/password_manager/core/browser/sync/credential_model_type_controller.cc;l=79-108;drc=ba4330ad08ffeef7b635dbd0bfe9ebcf52d13891

2. Forbidding transport mode for explicit passphrase users outside iOS:

This applies to both types, so the logic is kept in both controllers.
(There's no corresponding UI to enter the passphrase, so this spares
unnecessarily downloading data which will never be decrypted.
In fact, the same goes for all types supporting encryption so it
should probably be done centrally).
https://source.chromium.org/chromium/chromium/src/+/main:components/password_manager/core/browser/sync/credential_model_type_controller.cc;l=63-72;drc=ba4330ad08ffeef7b635dbd0bfe9ebcf52d13891

Bug: 1484531
Change-Id: I2d4e8a38f10499e592e71478096a6ec0f74c4117
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5097286
Code-Coverage: [email protected] <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Commit-Queue: Victor Vianna <[email protected]>
Reviewed-by: Martin Kreichgauer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1236234}
9 files changed
tree: 13f2b80de92fb22c61cef1901cb02f7f62007735
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.