Google Git
Sign in
chromium / chromium / src / 8c96a266310a8440b96ae4ffa48ef2d7c6ec953d
commit8c96a266310a8440b96ae4ffa48ef2d7c6ec953d[log] [tgz]
authorMikel Astiz <[email protected]>Thu Oct 26 16:59:55 2023
committerChromium LUCI CQ <[email protected]>Thu Oct 26 16:59:55 2023
treee5b3644a485179e53ea91f02441cf3c849dbc94e
parentcaf48951e93201d3f59c32c77332d85143ce8834 [diff]
[sync] Add virtual functions to BookmarkModelView

No behavioral differences, pure refactoring with semi-trivial
plumbing.

Adding virtual functions to BookmarkModelView allows, in later patches,
the customization of how the sync-relevant bookmark tree maps to the
local BookmarkModel.

For now, a single subclass is introduced, which implements the very
same behavior as before the patch.

Design doc (sorry, Googlers only):
https://docs.google.com/document/d/1i9XuP0lXOvEbvlwXre-EXMum4dxs_UToCsCcImIPEQU/edit?usp=sharing&resourcekey=0-1t7DIB0kTwaaGMmxtiZLqw

Change-Id: I187d03790d3f4b91a0826509f381bcfeeff0e234
Bug: 1494120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4967493
Reviewed-by: Rushan Suleymanov <[email protected]>
Auto-Submit: Mikel Astiz <[email protected]>
Reviewed-by: Ankush Singh <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1215583}
17 files changed
tree: e5b3644a485179e53ea91f02441cf3c849dbc94e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.