Skip to content

Conversation

@otoolep
Copy link
Contributor

@otoolep otoolep commented Jan 2, 2021

Will help fix rqlite/rqlite#530

@codecov-io
Copy link

codecov-io commented Jan 2, 2021

Codecov Report

Merging #900 (4823017) into master (3cbdae7) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
+ Coverage   46.80%   46.98%   +0.17%     
==========================================
  Files          11       11              
  Lines        1457     1458       +1     
==========================================
+ Hits          682      685       +3     
+ Misses        640      639       -1     
+ Partials      135      134       -1     
Impacted Files Coverage Δ
sqlite3.go 53.34% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cbdae7...4823017. Read the comment docs.

@otoolep
Copy link
Contributor Author

otoolep commented Jan 11, 2021

Any plans to merge this? Or do I need to proceed with my own fork?

@otoolep
Copy link
Contributor Author

otoolep commented Jan 22, 2021

Still no plan to merge this into the master branch?

@mattn mattn merged commit 95e88ca into mattn:master Feb 18, 2021
@mattn
Copy link
Owner

mattn commented Feb 18, 2021

Thank you

@otoolep
Copy link
Contributor Author

otoolep commented Feb 18, 2021

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include table name at least for joins in the resulting columns array

3 participants