feat: select early muxer #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements early multiplexer negotiation to save multistream-select round trips when a connection is opened. Spec: https://github.com/libp2p/specs/blob/6d38f88f7b2d16b0e4489298bcd0737a6d704f7e/connections/inlined-muxer-negotiation.md#multiplexer-negotiation-over-noise
d2275ef to
ac4f5d5
Compare
achingbrain
added a commit
to libp2p/js-libp2p
that referenced
this pull request
Mar 6, 2025
Compatibility fix ahead of ChainSafe/js-libp2p-noise#482
3 tasks
achingbrain
added a commit
to libp2p/js-libp2p
that referenced
this pull request
Mar 6, 2025
Compatibility fix ahead of ChainSafe/js-libp2p-noise#482
wemeetagain
approved these changes
Mar 20, 2025
Member
wemeetagain
left a comment
There was a problem hiding this comment.
Is this feature backwards compatible?
for example, if the client sends muxers, but the server doesn't recognize this feature yet, will the handshake succeed?
Collaborator
Author
|
Yes, if no muxer is agreed on using early data, the peers will fall back to using multistream-select to negotiate the muxer. |
wemeetagain
pushed a commit
that referenced
this pull request
Mar 20, 2025
## [16.1.0](v16.0.3...v16.1.0) (2025-03-20) ### Features * select early muxer ([#482](#482)) ([58c9fb9](58c9fb9))
Member
|
🎉 This PR is included in version 16.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements early multiplexer negotiation to save multistream-select round trips when a connection is opened.
Spec: https://github.com/libp2p/specs/blob/6d38f88f7b2d16b0e4489298bcd0737a6d704f7e/connections/inlined-muxer-negotiation.md#multiplexer-negotiation-over-noise