Add nix env shell
#10807
Merged
Add nix env shell
#10807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberth
commented
May 30, 2024
Comment on lines
7
to
25
| struct CmdEnv : NixMultiCommand | ||
| { | ||
| CmdEnv() : NixMultiCommand("env", RegisterCommand::getCommandsFor({"env"})) | ||
| { } | ||
|
|
||
| std::string description() override | ||
| { | ||
| return "manipulate the process environment"; | ||
| } | ||
|
|
||
| Category category() override { return catUtility; } | ||
| }; | ||
|
|
||
| static auto rCmdEnv = registerCommand<CmdEnv>("env"); |
Member
Author
There was a problem hiding this comment.
This is new and perfectly analogous to CmdStore.
| } | ||
| }; | ||
|
|
||
| static auto rCmdShell = registerCommand2<CmdShell>({"env", "shell"}); |
Member
Author
There was a problem hiding this comment.
Moved verbatim, except for the last line.
The last line has the canonical name, which appears in the help.
nix shell --help opens that page directly, and all the rest is also transparently aliased, without warning.
73c8e1f to
d93cc11
Compare
Ericson2314
approved these changes
May 30, 2024
Mic92
reviewed
May 31, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Start implementing #10504.
Most of the code has just moved to
env.cc.Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.