Skip to content

Commit fb7ec9b

Browse files
authored
dependencies: iluwatar#2449 bump maven-checkstyle-plugin from 3.1.0 to 3.2.0 + resolve chec… (iluwatar#2464)
* iluwatar#2449 bump maven-checkstyle-plugin from 3.1.0 to 3.2.0 + resolve checkstyle issues * remove FileSelectorJFrame.java to resolve checkstyle issue * remove FileSelectorJFrame.java to resolve checkstyle issue * remove FileSelectorJFrame.java to resolve checkstyle issue * add refactored file with correct filename to resolve checkstyle issue * add the test data * change filenames from JFrame to Jframe for checkstyle * fix code smell from sonar report * add new testcases to improve the test coverage * remove code smell
1 parent dbecffa commit fb7ec9b

File tree

147 files changed

+486
-288
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

147 files changed

+486
-288
lines changed

abstract-document/src/test/java/com/iluwatar/abstractdocument/AbstractDocumentTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
package com.iluwatar.abstractdocument;
2626

2727
import org.junit.jupiter.api.Test;
28-
2928
import java.util.HashMap;
3029
import java.util.List;
3130
import java.util.Map;

abstract-document/src/test/java/com/iluwatar/abstractdocument/DomainTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import com.iluwatar.abstractdocument.domain.Part;
2929
import com.iluwatar.abstractdocument.domain.enums.Property;
3030
import org.junit.jupiter.api.Test;
31-
3231
import java.util.List;
3332
import java.util.Map;
3433

abstract-factory/src/main/java/com/iluwatar/abstractfactory/Kingdom.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@
2727
import lombok.Getter;
2828
import lombok.Setter;
2929

30+
/**
31+
* Helper class to manufacture {@link KingdomFactory} beans.
32+
*/
3033
@Getter
3134
@Setter
3235
public class Kingdom {

active-object/src/main/java/com/iluwatar/activeobject/ActiveCreature.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626

2727
import java.util.concurrent.BlockingQueue;
2828
import java.util.concurrent.LinkedBlockingQueue;
29-
3029
import org.slf4j.Logger;
3130
import org.slf4j.LoggerFactory;
3231

@@ -77,8 +76,8 @@ protected ActiveCreature(String name) {
7776
*/
7877
public void eat() throws InterruptedException {
7978
requests.put(() -> {
80-
logger.info("{} is eating!",name());
81-
logger.info("{} has finished eating!",name());
79+
logger.info("{} is eating!", name());
80+
logger.info("{} has finished eating!", name());
8281
});
8382
}
8483

@@ -88,7 +87,7 @@ public void eat() throws InterruptedException {
8887
*/
8988
public void roam() throws InterruptedException {
9089
requests.put(() ->
91-
logger.info("{} has started to roam in the wastelands.",name())
90+
logger.info("{} has started to roam in the wastelands.", name())
9291
);
9392
}
9493

active-object/src/main/java/com/iluwatar/activeobject/App.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626

2727
import java.util.ArrayList;
2828
import java.util.List;
29-
3029
import org.slf4j.Logger;
3130
import org.slf4j.LoggerFactory;
3231

@@ -58,7 +57,7 @@ public static void main(String[] args) {
5857
public void run() {
5958
List<ActiveCreature> creatures = new ArrayList<>();
6059
try {
61-
for (int i = 0;i < NUM_CREATURES;i++) {
60+
for (int i = 0; i < NUM_CREATURES; i++) {
6261
creatures.add(new Orc(Orc.class.getSimpleName() + i));
6362
creatures.get(i).eat();
6463
creatures.get(i).roam();
@@ -68,7 +67,7 @@ public void run() {
6867
logger.error(e.getMessage());
6968
Thread.currentThread().interrupt();
7069
} finally {
71-
for (int i = 0;i < NUM_CREATURES;i++) {
70+
for (int i = 0; i < NUM_CREATURES; i++) {
7271
creatures.get(i).kill(0);
7372
}
7473
}

adapter/src/test/java/com/iluwatar/adapter/AdapterPatternTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626

2727
import org.junit.jupiter.api.BeforeEach;
2828
import org.junit.jupiter.api.Test;
29-
3029
import java.util.HashMap;
3130
import java.util.Map;
3231

business-delegate/src/test/java/com/iluwatar/business/delegate/AppTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
package com.iluwatar.business.delegate;
2626

2727
import org.junit.jupiter.api.Test;
28-
2928
import java.io.IOException;
3029

3130
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;

caching/src/main/java/com/iluwatar/caching/AppManager.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@
2525
package com.iluwatar.caching;
2626

2727
import com.iluwatar.caching.database.DbManager;
28-
2928
import java.util.Optional;
30-
3129
import lombok.extern.slf4j.Slf4j;
3230

3331
/**

caching/src/main/java/com/iluwatar/caching/CacheStore.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import java.util.List;
2929
import java.util.Optional;
3030
import java.util.stream.Collectors;
31-
3231
import lombok.extern.slf4j.Slf4j;
3332

3433
/**

caching/src/main/java/com/iluwatar/caching/database/MongoDb.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public class MongoDb implements DbManager {
5252
private MongoClient client;
5353
private MongoDatabase db;
5454

55-
void setDB(MongoDatabase db) {
55+
void setDb(MongoDatabase db) {
5656
this.db = db;
5757
}
5858

0 commit comments

Comments
 (0)