Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: android/compose-samples
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: nigma-dev/compose-samples
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cb/chat-imeanimation-30
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jan 15, 2021

  1. Disable window insets animations on API < 30 

    There are currently issues in WindowInsetsAnimationCompat
(likely https://issuetracker.google.com/175391720).
We'll re-enable at a later date once the issues are ironed out.
    @chrisbanes
    chrisbanes committed Jan 15, 2021
    Copy the full SHA
    24414c3 View commit details
Showing with 4 additions and 1 deletion.
  1. +4 −1 Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/ConversationFragment.kt
5 changes: 4 additions & 1 deletion Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/ConversationFragment.kt
View file
Original file line number Diff line number Diff line change
@@ -16,6 +16,7 @@

package com.example.compose.jetchat.conversation

import android.os.Build
import android.os.Bundle
import android.view.LayoutInflater
import android.view.View
@@ -55,7 +56,9 @@ class ConversationFragment : Fragment() {
// We use the `windowInsetsAnimationsEnabled` parameter to enable animated
// insets support. This allows our `ConversationContent` to animate with the
// on-screen keyboard (IME) as it enters/exits the screen.
.start(windowInsetsAnimationsEnabled = true)
// We only enable this on API 30+ (for now), due to
// https://issuetracker.google.com/175391720. Hopefully fixed in Core 1.5.0-beta02
.start(windowInsetsAnimationsEnabled = Build.VERSION.SDK_INT >= 30)

setContent {
Providers(