Skip to content

Commit 6cf698c

Browse files
author
Erik Ritter
authored
chore: deprecate REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD (#11244)
1 parent ae87b0c commit 6cf698c

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

UPDATING.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ assists people when migrating to a new version.
2323

2424
## Next
2525

26+
* [11244](https://github.com/apache/incubator-superset/pull/11244): The `REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD` feature flag has been removed after being set to True for multiple months.
27+
2628
* [11172](https://github.com/apache/incubator-superset/pull/11172): Breaking change: SQL templating is turned off be default. To turn it on set `ENABLE_TEMPLATE_PROCESSING` to True on `DEFAULT_FEATURE_FLAGS`
2729

2830
* [11155](https://github.com/apache/incubator-superset/pull/11155): The `FAB_UPDATE_PERMS` config parameter is no longer required as the Superset application correctly informs FAB under which context permissions should be updated.

superset/config.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,6 @@ def _try_json_readsha( # pylint: disable=unused-argument
302302
"PRESTO_EXPAND_DATA": False,
303303
# Exposes API endpoint to compute thumbnails
304304
"THUMBNAILS": False,
305-
"REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD": True,
306305
"REMOVE_SLICE_LEVEL_LABEL_COLORS": False,
307306
"SHARE_QUERIES_VIA_KV_STORE": False,
308307
"SIP_38_VIZ_REARCHITECTURE": False,
@@ -628,11 +627,11 @@ class CeleryConfig: # pylint: disable=too-few-public-methods
628627
# db configuration and a result of this function.
629628

630629
# mypy doesn't catch that if case ensures list content being always str
631-
ALLOWED_USER_CSV_SCHEMA_FUNC: Callable[
632-
["Database", "models.User"], List[str]
633-
] = lambda database, user: [
634-
UPLOADED_CSV_HIVE_NAMESPACE
635-
] if UPLOADED_CSV_HIVE_NAMESPACE else []
630+
ALLOWED_USER_CSV_SCHEMA_FUNC: Callable[["Database", "models.User"], List[str]] = (
631+
lambda database, user: [UPLOADED_CSV_HIVE_NAMESPACE]
632+
if UPLOADED_CSV_HIVE_NAMESPACE
633+
else []
634+
)
636635

637636
# Values that should be treated as nulls for the csv uploads.
638637
CSV_DEFAULT_NA_NAMES = list(STR_NA_VALUES)

superset/views/core.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1626,8 +1626,6 @@ def dashboard( # pylint: disable=too-many-locals
16261626
# Filter out unneeded fields from the datasource payload
16271627
datasources_payload = {
16281628
datasource.uid: datasource.data_for_slices(slices)
1629-
if is_feature_enabled("REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD")
1630-
else datasource.data
16311629
for datasource, slices in datasources.items()
16321630
}
16331631

0 commit comments

Comments
 (0)