fail on empty imds profile env

Author: lucix-aws

config/config_test.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"os"
 	"reflect"
+	"strings"
 	"testing"
 
 	"github.com/aws/aws-sdk-go-v2/aws"
@@ -148,6 +149,17 @@ func TestLoadDefaultConfig(t *testing.T) {
 	}
 }
 
+func TestLoadDefaultConfig_EmptyEC2InstanceProfileName(t *testing.T) {
+	t.Setenv(awsEc2InstanceProfileNameEnv, "")
+	_, err := LoadDefaultConfig(context.TODO())
+	if err == nil {
+		t.Fatal("expect error, got none")
+	}
+	if expect, actual := "env AWS_EC2_INSTANCE_PROFILE_NAME cannot be empty", err.Error(); !strings.Contains(actual, expect) {
+		t.Fatalf("expect error %s, got %s", expect, actual)
+	}
+}
+
 func BenchmarkLoadProfile1(b *testing.B) {
 	benchConfigLoad(b, 1)
 }

config/env_config.go

@@ -352,7 +352,11 @@ func NewEnvConfig() (EnvConfig, error) {
 
 	cfg.AppID = os.Getenv(awsSdkUaAppIDEnv)
 
-	cfg.EC2InstanceProfileName = os.Getenv(awsEc2InstanceProfileNameEnv)
+	ec2InstanceProfileName, ok := os.LookupEnv(awsEc2InstanceProfileNameEnv)
+	if ok && ec2InstanceProfileName == "" {
+		return cfg, fmt.Errorf("env %s cannot be empty", awsEc2InstanceProfileNameEnv)
+	}
+	cfg.EC2InstanceProfileName = ec2InstanceProfileName
 
 	if err := setBoolPtrFromEnvVal(&cfg.DisableRequestCompression, []string{awsDisableRequestCompressionEnv}); err != nil {
 		return cfg, err