Remove Unretryable Error Logic

[natemort]

Is your feature request related to a problem? Please describe.
This is specific to the Go client, but posting here to centralize issues more.

If the server returns a NonRetryableError the worker tries to terminate its own process. This is bad.

Proposed Solution
Remove this logic entirely. We should log quite clearly that we're receiving some critical error, but we can just keep trying the poll requests. Invalid requests are not a serious risk to either the server or the client. We should never be terminating the process.

Additional context
Add any other context or screenshots about the feature request here.

[MPAdler]

Hi, can I work on this issue?

[natemort]

Yeah, sure thing! Let me know if you have any questions about it. Feel free to reach out here or in the CNCF slack.

[MPAdler]

Hi! Quick update.

I was able to adjust the logic so non-retriable errors are reported and polling continues as intended, and cleaned up the corresponding unused imports.

However, I ran into issues running the tests on Windows. Some tests (TestCreateWorkerRun) fail with not supported by windows, and I’m not fully sure yet what the correct approach is there (skip, platform guard, or something else). I didn’t want to push changes that might be incorrect or break cross-platform behavior.

Sorry for the beginner mistake — any guidance on how Windows is expected to be handled here would be really appreciated.

[natemort]

Hey, no worries about that at all. Feel free to open a PR with what you have and I can take a look to better understand the issues. With the open PR we can run the tests via Github actions.

I'm not familiar with the issues running the tests on Windows unfortunately. I think we mostly use MacOS or Linux.