Fix season actions (#2031)

Author: chrisbanes

android-app/app/src/main/kotlin/app/tivi/home/MainActivity.kt

@@ -31,10 +31,10 @@ import app.tivi.inject.create
 import app.tivi.navigation.DeepLinker
 import app.tivi.screens.DiscoverScreen
 import app.tivi.settings.TiviPreferences
+import app.tivi.util.launchOrThrow
 import com.eygraber.uri.toUri
 import com.slack.circuit.backstack.rememberSaveableBackStack
 import com.slack.circuit.foundation.rememberCircuitNavigator
-import kotlinx.coroutines.launch
 
 class MainActivity : TiviActivity() {
 
@@ -51,7 +51,7 @@ class MainActivity : TiviActivity() {
 
     deepLinker = applicationComponent.deepLinker
 
-    lifecycle.coroutineScope.launch {
+    lifecycle.coroutineScope.launchOrThrow {
       repeatOnLifecycle(Lifecycle.State.STARTED) {
         applicationComponent.preferences.theme.flow
           .collect(::enableEdgeToEdgeForTheme)

api/tmdb/src/commonMain/kotlin/app/tivi/tmdb/TmdbInitializer.kt

@@ -5,7 +5,7 @@ package app.tivi.tmdb
 
 import app.tivi.appinitializers.AppInitializer
 import app.tivi.inject.ApplicationCoroutineScope
-import kotlinx.coroutines.launch
+import app.tivi.util.launchOrThrow
 import me.tatarka.inject.annotations.Inject
 
 @Inject
@@ -14,7 +14,7 @@ class TmdbInitializer(
   private val scope: ApplicationCoroutineScope,
 ) : AppInitializer {
   override fun initialize() {
-    scope.launch {
+    scope.launchOrThrow {
       tmdbManager.value.refreshConfiguration()
     }
   }

common/imageloading/src/commonMain/kotlin/app/tivi/common/imageloading/ImageLoaderCleanupInitializer.kt

@@ -7,7 +7,7 @@ import app.tivi.app.ApplicationInfo
 import app.tivi.appinitializers.AppInitializer
 import app.tivi.inject.ApplicationCoroutineScope
 import app.tivi.util.AppCoroutineDispatchers
-import kotlinx.coroutines.launch
+import app.tivi.util.launchOrThrow
 import me.tatarka.inject.annotations.Inject
 import okio.FileSystem
 import okio.Path.Companion.toPath
@@ -21,7 +21,7 @@ class ImageLoaderCleanupInitializer(
 ) : AppInitializer {
 
   override fun initialize() {
-    scope.launch(dispatchers.io) {
+    scope.launchOrThrow(dispatchers.io) {
       // We delete ImageLoader's disk cache folder to claim back space for the user
       val cachePath = applicationInfo.cachePath().toPath()
       val fs = fileSystem.value

common/ui/circuit/src/commonMain/kotlin/app/tivi/overlays/BottomSheetOverlay.kt

@@ -15,6 +15,7 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.graphics.isSpecified
 import androidx.compose.ui.unit.Dp
+import app.tivi.util.launchOrThrow
 import com.slack.circuit.foundation.CircuitContent
 import com.slack.circuit.foundation.NavEvent
 import com.slack.circuit.foundation.internal.BackHandler
@@ -24,7 +25,6 @@ import com.slack.circuit.overlay.OverlayHost
 import com.slack.circuit.overlay.OverlayNavigator
 import com.slack.circuit.runtime.Navigator
 import com.slack.circuit.runtime.screen.Screen
-import kotlinx.coroutines.launch
 
 @OptIn(ExperimentalMaterial3Api::class)
 class BottomSheetOverlay<Model : Any, Result : Any>(
@@ -43,7 +43,7 @@ class BottomSheetOverlay<Model : Any, Result : Any>(
     val coroutineScope = rememberCoroutineScope()
     BackHandler(enabled = sheetState.isVisible) {
       coroutineScope
-        .launch { sheetState.hide() }
+        .launchOrThrow { sheetState.hide() }
         .invokeOnCompletion {
           if (!sheetState.isVisible) {
             navigator.finish(onDismiss())
@@ -57,7 +57,7 @@ class BottomSheetOverlay<Model : Any, Result : Any>(
         // Delay setting the result until we've finished dismissing
         content(model) { result ->
           // This is the OverlayNavigator.finish() callback
-          coroutineScope.launch {
+          coroutineScope.launchOrThrow {
             try {
               sheetState.hide()
             } finally {

common/ui/circuit/src/commonMain/kotlin/app/tivi/overlays/DialogOverlay.kt

@@ -8,13 +8,13 @@ import androidx.compose.material3.Surface
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.rememberCoroutineScope
 import androidx.compose.ui.window.Dialog
+import app.tivi.util.launchOrThrow
 import com.slack.circuit.foundation.CircuitContent
 import com.slack.circuit.foundation.NavEvent
 import com.slack.circuit.overlay.Overlay
 import com.slack.circuit.overlay.OverlayHost
 import com.slack.circuit.overlay.OverlayNavigator
 import com.slack.circuit.runtime.screen.Screen
-import kotlinx.coroutines.launch
 
 class DialogOverlay<Model : Any, Result : Any>(
   private val model: Model,
@@ -35,7 +35,7 @@ class DialogOverlay<Model : Any, Result : Any>(
         // Delay setting the result until we've finished dismissing
         content(model) { result ->
           // This is the OverlayNavigator.finish() callback
-          coroutineScope.launch {
+          coroutineScope.launchOrThrow {
             navigator.finish(result)
           }
         }

common/ui/compose/src/commonMain/kotlin/app/tivi/common/compose/EntryGrid.kt

@@ -75,8 +75,8 @@ import app.tivi.data.models.Entry
 import app.tivi.data.models.TiviShow
 import app.tivi.data.models.TrendingShowEntry
 import app.tivi.util.fmt
+import app.tivi.util.launchOrThrow
 import kotlin.math.roundToInt
-import kotlinx.coroutines.launch
 import org.jetbrains.compose.resources.stringResource
 
 @OptIn(
@@ -126,7 +126,7 @@ fun <E : Entry> EntryGrid(
         onRefreshActionClick = lazyPagingItems::refresh,
         modifier = Modifier
           .noIndicationClickable {
-            coroutineScope.launch {
+            coroutineScope.launchOrThrow {
               lazyGridState.animateScrollToItem(0)
             }
           }

core/analytics/src/commonMain/kotlin/app/tivi/core/analytics/AnalyticsInitializer.kt

@@ -6,7 +6,7 @@ package app.tivi.core.analytics
 import app.tivi.appinitializers.AppInitializer
 import app.tivi.inject.ApplicationCoroutineScope
 import app.tivi.settings.TiviPreferences
-import kotlinx.coroutines.launch
+import app.tivi.util.launchOrThrow
 import me.tatarka.inject.annotations.Inject
 
 @Inject
@@ -16,7 +16,7 @@ class AnalyticsInitializer(
   private val scope: ApplicationCoroutineScope,
 ) : AppInitializer {
   override fun initialize() {
-    scope.launch {
+    scope.launchOrThrow {
       preferences.value.reportAnalytics.flow
         .collect { enabled -> analytics.value.setEnabled(enabled) }
     }

core/base/src/commonMain/kotlin/app/tivi/util/CoroutineContext.kt

@@ -0,0 +1,21 @@
+// Copyright 2024, Christopher Banes and the Tivi project contributors
+// SPDX-License-Identifier: Apache-2.0
+
+package app.tivi.util
+
+import kotlin.coroutines.CoroutineContext
+import kotlin.coroutines.EmptyCoroutineContext
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.CoroutineStart
+import kotlinx.coroutines.Job
+import kotlinx.coroutines.launch
+
+fun CoroutineScope.launchOrThrow(
+  context: CoroutineContext = EmptyCoroutineContext,
+  start: CoroutineStart = CoroutineStart.DEFAULT,
+  block: suspend CoroutineScope.() -> Unit,
+): Job = launch(context, start, block).also {
+  check(!it.isCancelled) {
+    "launch failed. Job is already cancelled"
+  }
+}

core/logging/src/commonMain/kotlin/app/tivi/util/CrashReportingInitializer.kt

@@ -6,7 +6,6 @@ package app.tivi.util
 import app.tivi.appinitializers.AppInitializer
 import app.tivi.inject.ApplicationCoroutineScope
 import app.tivi.settings.TiviPreferences
-import kotlinx.coroutines.launch
 import me.tatarka.inject.annotations.Inject
 
 @Inject
@@ -16,7 +15,7 @@ class CrashReportingInitializer(
   private val scope: ApplicationCoroutineScope,
 ) : AppInitializer {
   override fun initialize() {
-    scope.launch {
+    scope.launchOrThrow {
       preferences.value.reportAppCrashes.flow
         .collect { action.value(it) }
     }

core/notifications/core/src/androidMain/kotlin/app/tivi/core/notifications/PostNotificationBroadcastReceiver.kt

@@ -12,9 +12,9 @@ import android.net.Uri
 import android.util.Log
 import androidx.core.app.NotificationCompat
 import androidx.core.app.NotificationManagerCompat
+import app.tivi.util.launchOrThrow
 import kotlinx.coroutines.DelicateCoroutinesApi
 import kotlinx.coroutines.GlobalScope
-import kotlinx.coroutines.launch
 
 class PostNotificationBroadcastReceiver : BroadcastReceiver() {
 
@@ -33,11 +33,11 @@ class PostNotificationBroadcastReceiver : BroadcastReceiver() {
     val store = context.pendingNotificationsStore
     val result = goAsync()
 
-    GlobalScope.launch {
+    GlobalScope.launchOrThrow {
       val pending = store.findWithId(id) ?: run {
         Log.d(TAG, "Pending Notification with ID: $id not found. Exiting.")
         result.finish()
-        return@launch
+        return@launchOrThrow
       }
 
       Log.d(TAG, "Found pending notification with ID: $id: $pending")