_scripts: update staticcheck version (#3839)

aarzilli · web-flow · commit 2a9af735d093 · 2024-10-23T12:40:35.000-07:00
Update version of staticcheck and reenable for go1.23
diff --git a/_scripts/test_linux.sh b/_scripts/test_linux.sh
@@ -54,7 +54,7 @@ export GOPATH
 export PATH=$PATH:$GOROOT/bin:$GOPATH/bin
 go version
 if [ "$arch" != "ppc64le" ]; then
-	go install honnef.co/go/tools/cmd/staticcheck@2023.1.6 || true
+	go install honnef.co/go/tools/cmd/staticcheck@2024.1.1 || true
 fi
 
 uname -a
diff --git a/cmd/dlv/dlv_test.go b/cmd/dlv/dlv_test.go
@@ -1410,9 +1410,6 @@ func TestVersion(t *testing.T) {
 }
 
 func TestStaticcheck(t *testing.T) {
-	if goversion.VersionAfterOrEqual(runtime.Version(), 1, 23) {
-		t.Skip("staticcheck does not support go1.23 yet")
-	}
 	_, err := exec.LookPath("staticcheck")
 	if err != nil {
 		t.Skip("staticcheck not installed")

Original file line number	Diff line number	Diff line change
`@@ -1410,9 +1410,6 @@ func TestVersion(t *testing.T) {`
`1410`	`1410`	`}`
`1411`	`1411`
`1412`	`1412`	`func TestStaticcheck(t *testing.T) {`
`1413`		`- if goversion.VersionAfterOrEqual(runtime.Version(), 1, 23) {`
`1414`		`- t.Skip("staticcheck does not support go1.23 yet")`
`1415`		`- }`
`1416`	`1413`	`_, err := exec.LookPath("staticcheck")`
`1417`	`1414`	`if err != nil {`
`1418`	`1415`	`t.Skip("staticcheck not installed")`