Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: grpc/grpc-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: grpc/grpc-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.72.x
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 50 files changed
  • 6 contributors

Commits on Apr 7, 2025

  1. core: Avoid Set.removeAll() when passing a possibly-large List (#11994)…

    … (#12000)
    
    See #11958
    ejona86 authored Apr 7, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    666136b View commit details
  2. xds: ClusterResolverLoadBalancer handle update for both resolved addr…

    …esses and errors via ResolutionResult (#11997) (#12006)
    
    Backport of #11997 to v1.72.x.
    ------
    Fixes #11995
    kannanjgithub authored Apr 7, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    8681786 View commit details

Commits on Apr 8, 2025

  1. stub: trailersFromThrowable() metadata should be copied (#11979) (#12008

    )
    
    If the same exception is passed to multiple RPCs, then the results will race, which this fix addresses.
    
    Fixes #11973
    
    Co-authored-by: jiangyuan <joe469391363@gmail.com>
    ejona86 and JoeCqupt authored Apr 8, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    a6e1c1f View commit details

Commits on Apr 15, 2025

  1. stub: Utility method StreamObservers.nextAndComplete() that does both…

    … onNext and onComplete (#11778) (#12021)
    kannanjgithub authored Apr 15, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    b4e635d View commit details
  2. Copy the full SHA
    a2b642c View commit details
  3. Bump version to 1.72.0

    AgraVator committed Apr 15, 2025
    Copy the full SHA
    b0794e4 View commit details
  4. Bump version to 1.72.1-SNAPSHOT

    AgraVator committed Apr 15, 2025
    Copy the full SHA
    9e07406 View commit details

Commits on Apr 24, 2025

  1. xds: XdsDepManager should ignore updates after shutdown (#12038)

    This prevents a NPE and subsequent channel panic when trying to build a
    config (because there are no watchers, so waitingOnResource==false)
    without any listener and route.
    ```
    java.lang.NullPointerException: Cannot invoke "io.grpc.xds.XdsDependencyManager$RdsUpdateSupplier.getRdsUpdate()" because "routeSource" is null
        at io.grpc.xds.XdsDependencyManager.buildUpdate(XdsDependencyManager.java:295)
        at io.grpc.xds.XdsDependencyManager.maybePublishConfig(XdsDependencyManager.java:266)
        at io.grpc.xds.XdsDependencyManager$EdsWatcher.onChanged(XdsDependencyManager.java:899)
        at io.grpc.xds.XdsDependencyManager$EdsWatcher.onChanged(XdsDependencyManager.java:888)
        at io.grpc.xds.client.XdsClientImpl$ResourceSubscriber.notifyWatcher(XdsClientImpl.java:929)
        at io.grpc.xds.client.XdsClientImpl$ResourceSubscriber.lambda$onData$0(XdsClientImpl.java:837)
        at io.grpc.SynchronizationContext.drain(SynchronizationContext.java:96)
    ```
    
    I think this fully-fixes the problem today, but not tomorrow.
    subscribeToCluster() is racy as well, but not yet used.
    
    This was noticed when idleTimeout was firing, with some other code
    calling getState(true) to wake the channel back up. That may have made
    this panic more visible than it would be otherwise, but that has not
    been investigated.
    
    b/412474567
    ejona86 authored Apr 24, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    390bc33 View commit details

Commits on May 22, 2025

  1. Rename PSM interop fallback test suite to light (#12093)

    murgatroid99 authored May 22, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    ebee8f6 View commit details

Commits on May 23, 2025

  1. xds: propagate audience from cluster resource in gcp auth filter (#11972

    ) (#12088)
    shivaspeaks authored May 23, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    a2e53f6 View commit details
  2. xds: float LRU cache across interceptors (#11992) (#12096)

    shivaspeaks authored May 23, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    8bf12c6 View commit details
  3. xds: Add GcpAuthenticationFilter to FilterRegistry (#12075) (#12097)

    shivaspeaks authored May 23, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    c010742 View commit details
Loading