Skip to content

Commit 709e477

Browse files
committedMay 18, 2020
Update topics buttons.
1 parent aff7d39 commit 709e477

File tree

7 files changed

+22
-80
lines changed

7 files changed

+22
-80
lines changed
 

‎JetNews/app/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ dependencies {
6363
implementation("androidx.ui:ui-core:$compose_version")
6464
implementation("androidx.ui:ui-layout:$compose_version")
6565
implementation("androidx.ui:ui-material:$compose_version")
66+
implementation("androidx.ui:ui-material-icons-extended:$compose_version")
6667
implementation("androidx.ui:ui-foundation:$compose_version")
6768
implementation("androidx.ui:ui-animation:$compose_version")
6869
implementation "androidx.ui:ui-tooling:$compose_version"

‎JetNews/app/src/main/java/com/example/jetnews/ui/interests/SelectTopicButton.kt

+18-30
Original file line numberDiff line numberDiff line change
@@ -17,54 +17,42 @@
1717
package com.example.jetnews.ui.interests
1818

1919
import androidx.compose.Composable
20+
import androidx.compose.Pivotal
2021
import androidx.ui.core.Modifier
21-
import androidx.ui.foundation.Box
2222
import androidx.ui.foundation.Icon
2323
import androidx.ui.foundation.shape.corner.CircleShape
2424
import androidx.ui.layout.padding
2525
import androidx.ui.layout.preferredSize
26+
import androidx.ui.material.EmphasisAmbient
2627
import androidx.ui.material.MaterialTheme
27-
import androidx.ui.res.vectorResource
28+
import androidx.ui.material.ProvideEmphasis
29+
import androidx.ui.material.Surface
30+
import androidx.ui.material.icons.Icons
31+
import androidx.ui.material.icons.filled.Add
32+
import androidx.ui.material.icons.filled.Done
2833
import androidx.ui.tooling.preview.Preview
2934
import androidx.ui.unit.dp
30-
import com.example.jetnews.R
3135
import com.example.jetnews.ui.ThemedPreview
3236

3337
@Composable
3438
fun SelectTopicButton(
3539
modifier: Modifier = Modifier,
36-
selected: Boolean = false
40+
@Pivotal selected: Boolean = false
3741
) {
38-
if (selected) {
39-
SelectTopicButtonOn(modifier.preferredSize(36.dp, 36.dp))
42+
val icon = if (selected) Icons.Filled.Done else Icons.Filled.Add
43+
val backgroundColor = if (selected) {
44+
MaterialTheme.colors.primary
4045
} else {
41-
SelectTopicButtonOff(modifier.preferredSize(36.dp, 36.dp))
46+
MaterialTheme.colors.onSurface.copy(alpha = 0.12f)
4247
}
43-
}
44-
45-
@Composable
46-
private fun SelectTopicButtonOn(modifier: Modifier = Modifier) {
47-
Box(
48-
backgroundColor = MaterialTheme.colors.primary,
49-
shape = CircleShape,
50-
modifier = modifier
51-
) {
52-
Icon(
53-
asset = vectorResource(R.drawable.ic_check),
54-
tint = MaterialTheme.colors.onPrimary
55-
)
56-
}
57-
}
58-
59-
@Composable
60-
private fun SelectTopicButtonOff(modifier: Modifier = Modifier) {
61-
val borderColor = MaterialTheme.colors.onSurface.copy(alpha = 0.12f)
62-
Box(
63-
backgroundColor = borderColor,
48+
Surface(
49+
color = backgroundColor,
6450
shape = CircleShape,
65-
modifier = modifier
51+
modifier = modifier.preferredSize(36.dp, 36.dp)
6652
) {
67-
Icon(vectorResource(R.drawable.ic_add))
53+
ProvideEmphasis(EmphasisAmbient.current.high) {
54+
Icon(icon)
55+
}
6856
}
6957
}
7058

‎JetNews/app/src/main/res/drawable/ic_add.xml

-25
This file was deleted.

‎JetNews/app/src/main/res/drawable/ic_check.xml

-25
This file was deleted.
216 Bytes
Binary file not shown.

‎JetNews/gradlew

+2
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ esac
8282

8383
CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar
8484

85+
8586
# Determine the Java command to use to start the JVM.
8687
if [ -n "$JAVA_HOME" ] ; then
8788
if [ -x "$JAVA_HOME/jre/sh/java" ] ; then
@@ -129,6 +130,7 @@ fi
129130
if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
130131
APP_HOME=`cygpath --path --mixed "$APP_HOME"`
131132
CLASSPATH=`cygpath --path --mixed "$CLASSPATH"`
133+
132134
JAVACMD=`cygpath --unix "$JAVACMD"`
133135

134136
# We build the pattern for arguments to be converted via cygpath

‎JetNews/gradlew.bat

+1
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ set CMD_LINE_ARGS=%*
8484

8585
set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar
8686

87+
8788
@rem Execute Gradle
8889
"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %CMD_LINE_ARGS%
8990

0 commit comments

Comments
 (0)
Please sign in to comment.