audispd-pconfig.c: don't check unnecessary write permissions (#433)

nazarewk · web-flow · commit 1f31d79f0476 · 2025-02-03T20:27:17.000-05:00
diff --git a/audisp/audispd-pconfig.c b/audisp/audispd-pconfig.c
@@ -506,9 +506,9 @@ static int sanity_check(plugin_conf_t *config, const char *file)
 				 config->path);
 			return 1;
 		}
-		if ((buf.st_mode & (S_IRUSR|S_IWUSR|S_IXUSR|S_IRGRP|S_IXGRP)) !=
-				   (S_IRUSR|S_IWUSR|S_IXUSR|S_IRGRP|S_IXGRP)) {
-			audit_msg(LOG_ERR, "%s permissions should be 0750",
+		if ((buf.st_mode & (S_IRUSR|S_IXUSR|S_IRGRP|S_IXGRP)) !=
+				   (S_IRUSR|S_IXUSR|S_IRGRP|S_IXGRP)) {
+			audit_msg(LOG_ERR, "%s permissions should be at least 0550",
 				 config->path);
 			return 1;
 		}

Original file line number	Diff line number	Diff line change
`@@ -506,9 +506,9 @@ static int sanity_check(plugin_conf_t config, const char file)`
`506`	`506`	`config->path);`
`507`	`507`	`return 1;`
`508`	`508`	`}`
`509`		`- if ((buf.st_mode & (S_IRUSR\|S_IWUSR\|S_IXUSR\|S_IRGRP\|S_IXGRP)) !=`
`510`		`- (S_IRUSR\|S_IWUSR\|S_IXUSR\|S_IRGRP\|S_IXGRP)) {`
`511`		`- audit_msg(LOG_ERR, "%s permissions should be 0750",`
	`509`	`+ if ((buf.st_mode & (S_IRUSR\|S_IXUSR\|S_IRGRP\|S_IXGRP)) !=`
	`510`	`+ (S_IRUSR\|S_IXUSR\|S_IRGRP\|S_IXGRP)) {`
	`511`	`+ audit_msg(LOG_ERR, "%s permissions should be at least 0550",`
`512`	`512`	`config->path);`
`513`	`513`	`return 1;`
`514`	`514`	`}`