tree-wide:obsolete $(SDK) in conditionals

[danielfdickinson]

Package Name

tree-wide

Maintainer

@GeorgeSapkin @hnyman @mhei @gstrauss @systemcrash @commodo @nicolas-thill

OpenWrt Version

SNAPSHOT

OpenWrt Target/Subtarget

bcm27xx/bcm2712

Steps to Reproduce

1. Use SDK
2. make menuconfig
3. choose a subset of modules from packages like php8 or freeradius

Actual Behaviour

During compilation dependencies are unfulfilled and build fails.

Likely due to conditions like:

ifneq ($(SDK)$(CONFIG_PACKAGE_freeradius3-mod-cache-redis),)

which in the distant past were maybe meant to keep SDK builds from building packages with different configurations than base build.

There are only few packages that use this construct:

php8, freeradius3, libdbi-drivers, lighttpd, ulogd, and ntfs-3g .

It looks like recent changes related to apk and dependencies have resulted in a change in behaviour here (or I've just run across an longstanding situation).

It may be a while before I am able to look at this more deeply, but making note of it, as it might be more urgent for someone else.

Confirmation Checklist

• The package is maintained in this repository.
• I understand that issues related to the base OpenWrt repository or LuCI repository will be closed.
• I am reporting an issue for OpenWrt, not an unsupported fork.

[systemcrash]

See openwrt/openwrt@2da3f6a

[danielfdickinson]

@systemcrash Do you now if there was any discussion / further explanation that would help me understand why or how this is a fix, and whether it is still needed or applicable?

Right now my brain in not wrapping itself around this very well.

[systemcrash]

That long ago, any discussion is likely long gone. The mentioned commit seems to indicate it's just a check that we're in the openwrt SDK. I've not given it much more thought.

[danielfdickinson]

Ok. Thank you. I do seem to recall it being used to check if SDK, I just do not remember why that was (is?) important. I guess I'll have to try some builds, once the dependency breakage is sorted out.

[gstrauss]

I traced $(SDK) use back to the initial version of lighttpd/Makefile in git, but there is probably further history in Subversion before OpenWRT migrated from Subversion to git. I will remove the use in lighttpd in lighttpd 1.4.82-2, so please tag me if issues arise and get reported.

[gstrauss]

This would appear to suggest that $(SDK) for install targets is obsolete:
automa1on/openwrt-archive@6272e95

[danielfdickinson]

@gstrauss Thank you, and nice find on the automation.

[danielfdickinson]

So I've looked at this a little more. The reason it causes dependency issues is that (using libdbi-drivers as an example) lines like:

ifneq ($(SDK)$(CONFIG_PACKAGE_libdbd-sqlite3),)

always evaluate to true if you are compiling in the SDK. So for a user compiling from the SDK, the configure arguments are always added to the package build.

In the case of libdbi-drivers:

	CONFIGURE_ARGS += \
		--with-sqlite3 \
		--with-sqlite3-incdir=$(STAGING_DIR)/usr/include \
		--with-sqlite3-libdir=$(STAGING_DIR)/usr/lib

is always added even if PACKAGE_libdbd-sqlite3 is deselected. When libdbd-sqlite3 is deselected, this dependency:

DEPENDS:=libdbi +libsqlite3

is not present, so when configure tries to find sqlite3 it fails.

As this construct appears to be unused for a useful purpose, I believe @gstrauss' approach (simply remove the reference) is all that is required.

[mhei]

Thanks for the investigation. I'm fine with removing this flag (and if the removal causes regressions that we don't see at the moment, we can always revert).