cargo check uplifts dylibs to artifact-dir when proc-macro depends on dylib #16305
Description
Spinning a new issue out of #16297
Issue
The root issue here is that when a bin crate depends on a proc-macro crate which depends on a dylib crate.
In this scenario, the proc-macro crate is compiled in CompileMode::Build since we need to execute the proc-macro bin.
cargo/src/cargo/core/compiler/unit_dependencies.rs
Lines 819 to 823 in 23f5b2b
This causes the dylib crate to "inherit" the CompileMode::Build mode.
cargo/src/cargo/core/profiles.rs
Line 1192 in 23f5b2b
This causes Cargo to uplift the shared object by mistake in fn uplift_to()
cargo/src/cargo/core/compiler/build_runner/compilation_files.rs
Lines 428 to 430 in 23f5b2b
cargo/src/cargo/core/compiler/build_runner/compilation_files.rs
Lines 446 to 451 in 23f5b2b
Expected Behavior
Cargo should not uplift any artifacts to the artifact-dir when running cargo check