Negative offset with flag --enable-feature=promql-negative-offset

[vsile]

Prometheus v2.26.0 has the flag --enable-feature=promql-negative-offset to enable negative offset.
It works fine.

But I can't enable it with Thanos 0.19.0.
It looks like the flag is not available for Thanos Query.
So the next query my_metric_status offset -24h fails with the error 1:31: parse error: unexpected <op:-> in offset, expected duration

Is this feature implemented?

[yeya24]

No, it is not included in Thanos 0.19.0.
But as we use Prometheus as a library, this is easy to do.
Just add one more flag in querier to enable it. Help wanted.

[bwplotka]

Help wanted!

[bwplotka]

Discussion what's needed is here: #4026 (comment) 🤗

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Closing for now as promised, let us know if you need this to be reopened! 🤗

[vsile]

Hello!
I keep looking for a solution to enable negative offset in Thanos..

The PR of @yeya24 looks good.
It is unlikely that there will be many similar flags in Prometheus.
It would be fine to receive the PR in the current implementation.