Skip to content

Conversation

@Goooler
Copy link
Member

@Goooler Goooler commented Oct 3, 2025

@Goooler Goooler changed the title Don't set the group of startShadowScripts Change the group of startShadowScripts from application to other Oct 3, 2025
@Goooler Goooler requested a review from Copilot October 3, 2025 12:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the group assignment of the startShadowScripts task from application to other to align with how Gradle's ApplicationPlugin handles similar tasks.

  • Removes the explicit group assignment for startShadowScripts task, allowing it to default to other
  • Updates test expectations to reflect the group change
  • Adds changelog entry documenting the change

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.kt Removes explicit APPLICATION_GROUP assignment from startShadowScripts task
src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowPropertiesTest.kt Updates test to remove group assertion for startShadowScripts and adds import for APPLICATION_GROUP
docs/changes/README.md Documents the change in the unreleased changelog

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Goooler Goooler force-pushed the g/20251003/start-script-group branch from cca591e to c0824e4 Compare October 3, 2025 12:31
@Goooler Goooler enabled auto-merge (squash) October 3, 2025 12:32
@Goooler Goooler merged commit cf3c59c into main Oct 3, 2025
10 checks passed
@Goooler Goooler deleted the g/20251003/start-script-group branch October 3, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants