Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: influxdata/flux
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: influxdata/flux
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: mh-use-string-refs
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 26 files changed
  • 1 contributor

Commits on Jun 3, 2024

  1. feat: stop making string copies

    Undo the changes introduced in #5377. This is a trade-off where it
    is considerd better to have as much memory as possible allocated
    by the allocator, with the risk that it will be freed when still
    in use. Than to have significant amounts of memory allocated outside
    of the allocator.
    
    It should be noted that because of Go's garbage collector it is
    perfectly safe for memory to be "freed" when still in use. It just
    mean that any accounting done by the allocator will be inaccurate.
    mhilton committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    370e460 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. feat: remove unnecessary StringRef type

    Remove the recently added StringRef type as it is now unnecessary.
    mhilton committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    d620632 View commit details
    Browse the repository at this point in the history
Loading