Skip to content

Make sure to use a cached result when we have it so we wont detect it again #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2023
Merged

Make sure to use a cached result when we have it so we wont detect it again #54

merged 2 commits into from
Jan 13, 2023

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 12, 2023

Description:

The cache result methods were actually never called meaning it always tried to parse the user agent again.

Review

@tsteur tsteur added this to the Current sprint milestone Jan 12, 2023
@tsteur tsteur requested a review from sgiehl January 12, 2023 21:47
@sgiehl sgiehl merged commit 702aa50 into 4.x-dev Jan 13, 2023
@sgiehl sgiehl deleted the devicedetectorcache branch January 13, 2023 08:34
@innocraft-automation innocraft-automation removed this from the Current sprint milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsteur @sgiehl @innocraft-automation