Skip to content

Commit 00bccd7

Browse files
authoredMay 24, 2024
Remove eslint config package (#6970)
# Pull Request ## 📖 Description Removal of the `@microsoft/eslint-config-fast-dna` package as we reserve the right to change eslint configurations and will not be maintaining a package outside this repository. As such, the configuration options have been moved to the root `.eslintrc`. ### 🎫 Issues Resolves #6948 ## 👩‍💻 Reviewer Notes The logic has not changed here, we are only moving this package configuration options internal, and I have added "prettier" as an extension as all current packages re-extend it anyway. ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have included a change request file using `$ yarn change` - [ ] I have added tests for my changes. - [x] I have tested my changes. - [ ] I have updated the project documentation to reflect my changes. - [x] I have read the [CONTRIBUTING](https://github.com/microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](/docs/community/code-of-conduct/#our-standards) for this project.
1 parent 4a282ae commit 00bccd7

File tree

61 files changed

+254
-322
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+254
-322
lines changed
 

‎.eslintrc.js

+83-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,85 @@
11
module.exports = {
2-
extends: ["@microsoft/eslint-config-fast-dna", "prettier"],
2+
root: true,
3+
parser: "@typescript-eslint/parser",
4+
plugins: ["@typescript-eslint", "import"],
5+
extends: [
6+
"eslint:recommended",
7+
"plugin:@typescript-eslint/eslint-recommended",
8+
"plugin:@typescript-eslint/recommended",
9+
"prettier"
10+
],
11+
rules: {
12+
"no-unused-vars": "off",
13+
"no-extra-boolean-cast": "off",
14+
"no-empty-function": "off",
15+
"@typescript-eslint/no-empty-function": [
16+
"error",
17+
{ allow: ["asyncMethods", "methods"] },
18+
],
19+
"@typescript-eslint/no-use-before-define": "off",
20+
"@typescript-eslint/typedef": "off",
21+
"@typescript-eslint/explicit-function-return-type": "off",
22+
"max-len": ["error", 140],
23+
"import/order": "error",
24+
"sort-imports": [
25+
"error",
26+
{
27+
ignoreCase: true,
28+
ignoreDeclarationSort: true,
29+
},
30+
],
31+
"comma-dangle": "off",
32+
"@typescript-eslint/no-empty-interface": [
33+
"error",
34+
{
35+
allowSingleExtends: true,
36+
},
37+
],
38+
"@typescript-eslint/camelcase": "off",
39+
"@typescript-eslint/naming-convention": [
40+
"error",
41+
{
42+
selector: "default",
43+
format: ["UPPER_CASE", "camelCase", "PascalCase"],
44+
leadingUnderscore: "allow",
45+
},
46+
{
47+
selector: "property",
48+
format: null, // disable for property names because of our foo__expanded convention for JSS
49+
// TODO: I think we can come up with a regex that ignores variables with __ in them
50+
},
51+
{
52+
selector: "variable",
53+
format: null, // disable for variable names because of our foo__expanded convention for JSS
54+
// TODO: I think we can come up with a regex that ignores variables with __ in them
55+
},
56+
{
57+
selector: "interface",
58+
format: ["PascalCase"],
59+
custom: {
60+
regex: "^I[A-Z]",
61+
match: false,
62+
},
63+
},
64+
],
65+
"@typescript-eslint/no-inferrable-types": "off",
66+
"no-prototype-builtins": "off",
67+
"no-fallthrough": "off",
68+
"no-unexpected-multiline": "off",
69+
"@typescript-eslint/no-unused-vars": ["warn", { args: "none" }],
70+
"@typescript-eslint/no-explicit-any": "off",
71+
},
72+
overrides: [
73+
{
74+
files: ["**/*.js"],
75+
extends: ["eslint:recommended"],
76+
env: {
77+
node: true,
78+
"shared-node-browser": true,
79+
},
80+
rules: {
81+
"@typescript-eslint/no-var-requires": "off",
82+
},
83+
},
84+
],
385
};

‎.github/CODEOWNERS

-5
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,7 @@ build/ @janechu @nicholasrice @chrisdholt @awentzel
2828

2929
# Package specific owners
3030

31-
# Tooling
32-
/packages/tooling/fast-figma-plugin-msft/ @nicholasrice @bheston @janechu
33-
3431
# Utilities
35-
/packages/utilities/fast-animation/ @nicholasrice @chrisdholt
36-
/packages/utilities/fast-eslint-rules/ @nicholasrice @janechu @chrisdholt
3732
/packages/utilities/fast-web-utilities/ @janechu @chrisdholt @nicholasrice
3833

3934
# Web components

0 commit comments

Comments
 (0)