You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: BRANCH_GUIDE.md
+3-3
Original file line number
Diff line number
Diff line change
@@ -4,15 +4,15 @@ This is the branch guide for the FAST repository. When contributing to this proj
4
4
5
5
## Default
6
6
7
-
The `master` branch is the default branch. It is used for all releases pinned to the current major version. Most pull requests should be merged directly into this branch so that it can be automatically checked for publishing.
7
+
The `master` branch is the default branch. It is used for all releases pinned to the current major version. Most pull requests should be merged directly into this branch so that they can be automatically checked for publishing.
8
8
9
9
## Features
10
10
11
-
If a large feature or a breaking change has been defined, a feature branch may be created. To be significant enough work to require a feature branch, the work must comprise of more than one pull request. The feature branch should follow the naming convention `features/*`. This will allow GitHub workflows including the build gate to trigger on any pull request opened against the feature branch.
11
+
If a large feature or a breaking change has been defined, a feature branch may be created. To be significant enough work to require a feature branch, the work must comprise of more than one pull request. The feature branch should follow the naming convention `features/*`. This will allow GitHub workflows, including the build gate, to trigger on any pull request opened against the feature branch.
12
12
13
13
### Changelog
14
14
15
-
Due to the default behavior of beachball (the package publishing utility used in this repository) the `beachball.config.js` which defaults to checking for changes against the default branch must be updated to point to the feature branch, and if necessary, allowed to add major changes. The branch creation should start by updating `beachball.config.js`, to do this refer to the [beachball options](https://github.com/microsoft/beachball/blob/master/docs/overview/configuration.md#options). This change must be reverted before inclusion to the default branch.
15
+
Due to the default behavior of beachball (the package publishing utility used in this repository), the `beachball.config.js` which defaults to checking for changes against the default branch must be updated to point to the feature branch, and if necessary, allowed to add major changes. The branch creation should start by updating `beachball.config.js`, to do this refer to the [beachball options](https://github.com/microsoft/beachball/blob/master/docs/overview/configuration.md#options). This change must be reverted before inclusion to the default branch.
Copy file name to clipboardExpand all lines: CODE_OF_CONDUCT.md
+2-2
Original file line number
Diff line number
Diff line change
@@ -2,7 +2,7 @@
2
2
3
3
## Our Pledge
4
4
5
-
In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
5
+
In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to make participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
6
6
7
7
## Our Standards
8
8
@@ -19,7 +19,7 @@ Examples of unacceptable behavior by participants include:
19
19
* The use of sexualized language or imagery and unwelcome sexual attention or advances
20
20
* Trolling, insulting/derogatory comments, and personal or political attacks
21
21
* Public or private harassment
22
-
* Publishing others' private information, such as a physical or electronic address, without explicit permission
22
+
* Publishing other's private information, such as a physical or electronic address, without explicit permission
23
23
* Other conduct which could reasonably be considered inappropriate in a professional setting
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+13-13
Original file line number
Diff line number
Diff line change
@@ -23,7 +23,7 @@ yarn global add lerna
23
23
```
24
24
25
25
:::important
26
-
The above steps are a one-time setup for your machine and do not need to be repeated after the initial configuration.
26
+
The above steps are a one-time set up for your machine and do not need to be repeated after the initial configuration.
27
27
:::
28
28
29
29
### Cloning the repository
@@ -81,7 +81,7 @@ Packages are located within the `packages` folder of the repository. Each packag
81
81
If you'd like to contribute by fixing a bug, implementing a feature, or even correcting typos in our documentation, you'll want to submit a pull request. Before submitting a pull request, be sure to [rebase](https://www.atlassian.com/git/tutorials/merging-vs-rebasing) your branch (typically from master) or use the *merge* button provided by GitHub.
82
82
83
83
:::note
84
-
For additional details on branch management read the [branch guide](/docs/community/branch-guide) documentation.
84
+
For additional details on branch management, read the [branch guide](../community/branch-guide.md) documentation.
85
85
:::
86
86
87
87
#### Change Files
@@ -104,12 +104,12 @@ When working across feature branches, you'll need to target the branch using the
104
104
}
105
105
```
106
106
107
-
Running `yarn change` will walk you through a CLI process for generating change files. The process will walk you through selecting the type of change as well as ask you to provide a description of any changes. As a convenience, the utility looks to provide recent commit messages for use in the description. *For changes which do not affect the published package(s), please use "none" when selecting the change type*.
107
+
Running `yarn change` will walk you through a CLI process for generating change files. The process will walk you through selecting the type of change as well as ask you to provide a description of any changes. As a convenience, the utility looks to provide recent commit messages for use in the description. *For changes that do not affect the published package(s), please use "none" when selecting the change type*.
108
108
109
109
More information on the change process and change types can be found on the [Beachball website](https://microsoft.github.io/beachball/cli/change.html#change).
110
110
111
111
:::note
112
-
If you are addressing multiple issues which are unrelated, consider either doing multiple pull requests, or generate separate change files to ensure accurate generation of changelogs and versioning of packages.
112
+
If you are addressing multiple issues which are unrelated, consider either doing multiple pull requests, or generating separate change files to ensure accurate generation of changelogs and versioning of packages.
113
113
:::
114
114
115
115
:::note
@@ -151,7 +151,7 @@ When you submit a pull request, a CLA-bot automatically determines if you need t
151
151
152
152
## Guiding principle
153
153
154
-
Owners, the steering committee, collaborators, code owners, and contributors work in concert with one another on behalf of the FAST community and prioritize the communities interests over their own.
154
+
Owners, the steering committee, collaborators, code owners, and contributors work in concert with one another on behalf of the FAST community and prioritize the community's interests over their own.
155
155
156
156
The development, release, and work management processes must reflect this principle. Accepting contributions to the project requires a review by collaborators.
157
157
@@ -163,7 +163,7 @@ The development, release, and work management processes must reflect this princi
163
163
164
164
### Steering committee
165
165
166
-
*Steering committee* members are key *collaborators* who have demonstrated design or technical expertise critical to the driving the FAST project and community forward.
166
+
*Steering committee* members are key *collaborators* who have demonstrated design or technical expertise critical to driving the FAST project and community forward.
167
167
168
168
### Collaborators
169
169
@@ -180,9 +180,9 @@ As subject matter experts, *code owners* approve pull requests on the packages t
180
180
### Nominations & appointments
181
181
182
182
* To become a *contributor*, a community member must have a pull request approved and merged into the FAST project master branch.
183
-
* To become a *collaborator*, a *contributor* will petition the *steering committee* who will approve or deny the request.
184
-
* To become a *code owner*, a *collaborator* will be (a) nominated by a *steering committee* member or (b) petition the *steering committee* who will approve or deny the request.
185
-
* To join the *steering committee*, a *collaborator* will be nominated by a *steering committee* member and the *steering committee* who will approve or deny the request.
183
+
* To become a *collaborator*, a *contributor* will petition the *steering committee*, who will approve or deny the request.
184
+
* To become a *code owner*, a *collaborator* will be (a) nominated by a *steering committee* member or (b) petition the *steering committee*, who will approve or deny the request.
185
+
* To join the *steering committee*, a *collaborator* will be nominated by a *steering committee* member and the *steering committee*, who will approve or deny the request.
186
186
187
187
## Acceptance and consensus seeking process
188
188
@@ -192,12 +192,12 @@ All pull requests must be approved by an assigned *collaborator* before the pull
192
192
193
193
1. Reviewing the pull request if they are not the creator of it
194
194
2. Adding any additional reviewers to review at their discretion
195
-
3. Ensuring the the pull request is given feedback in [a reasonable period of time](#response-time) from *collaborators* or *code owners* with the expertise to evaluate the changes
195
+
3. Ensuring the pull request is given feedback in [a reasonable period of time](#response-time) from *collaborators* or *code owners* with the expertise to evaluate the changes
196
196
4. Merging the pull request
197
197
198
198
When a pull request : (a) has a significant impact on the project, (b) is inherently controversial, or (c) has not reached consensus with *collaborators*; add a "status:controversial" label to the pull request for the *steering committee* to review the pull request. Pull requests labeled with "status:controversial" are not approved until the *steering committee* reviews the issue and makes a decision.
199
199
200
-
Additionally, *owners*, can temporarily enable [interaction limits](https://help.github.com/articles/limiting-interactions-with-your-repository/) to allow a "cool-down" period when hot topics become disruptive.
200
+
Additionally, *owners* can temporarily enable [interaction limits](https://help.github.com/articles/limiting-interactions-with-your-repository/) to allow a "cool-down" period when hot topics become disruptive.
201
201
202
202
Specific *collaborators* or *code owners* can be added to a pull request by including their user alias in the "Reviewers" section.
203
203
@@ -207,15 +207,15 @@ The amount of time can vary but at least 3 days during the typical working week
207
207
208
208
## Stability policy
209
209
210
-
An essential consideration in every pull request is its impact on the system. To manage impacts, we work collectively to ensure that we do not introduce unnecessary breaking changes, performance or functional regressions, or negative impacts on usability for users or supported partners. To learn more about our approaches to planning and releases, see [our release planning document](/docs/community/release-planning).
210
+
An essential consideration in every pull request is its impact on the system. To manage impacts, we work collectively to ensure that we do not introduce unnecessary breaking changes, performance or functional regressions, or negative impacts on usability for users or supported partners. To learn more about our approaches to planning and releases, see [our release planning document](../community/release-planning.md).
211
211
212
212
## Developer's Certificate of Origin 1.1
213
213
214
214
By making a contribution to this project, I certify that:
215
215
216
216
* a. The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
217
217
* b. The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
218
-
* c. The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
218
+
* c. The contribution was provided directly to me by some other person who certified (a), (b), or (c) and I have not modified it.
219
219
* d. I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.
Copy file name to clipboardExpand all lines: SECURITY.md
+1-1
Original file line number
Diff line number
Diff line change
@@ -12,7 +12,7 @@ If you believe you have found a security vulnerability in any Microsoft-owned re
12
12
13
13
Instead, please report them to the Microsoft Security Response Center (MSRC) at [https://msrc.microsoft.com/create-report](https://msrc.microsoft.com/create-report).
14
14
15
-
If you prefer to submit without logging in, send email to [secure@microsoft.com](mailto:secure@microsoft.com). If possible, encrypt your message with our PGP key; please download it from the the [Microsoft Security Response Center PGP Key page](https://www.microsoft.com/en-us/msrc/pgp-key-msrc).
15
+
If you prefer to submit without logging in, send an email to [secure@microsoft.com](mailto:secure@microsoft.com). If possible, encrypt your message with our PGP key. Please download it from the [Microsoft Security Response Center PGP Key page](https://www.microsoft.com/en-us/msrc/pgp-key-msrc).
16
16
17
17
You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Additional information can be found at [microsoft.com/msrc](https://www.microsoft.com/msrc).
Copy file name to clipboardExpand all lines: packages/web-components/fast-element/README.md
+2-2
Original file line number
Diff line number
Diff line change
@@ -26,7 +26,7 @@ import { FASTElement } from '@microsoft/fast-element';
26
26
```
27
27
28
28
:::tip
29
-
Looking for a setup that integrates with a particular front-end framework or bundler? Check out [our integration docs](https://fast.design/docs/integrations/introduction).
29
+
Looking for a setup that integrates with a particular front-end framework or bundler? Check out [our integration docs](../integrations/introduction.md).
30
30
:::
31
31
32
32
### From CDN
@@ -58,5 +58,5 @@ For simplicity, examples throughout the documentation will assume the library ha
58
58
:::
59
59
60
60
:::tip
61
-
Looking for a quick guide on building components? Check out [our Cheat Sheet](https://www.fast.design/docs/resources/cheat-sheet#building-components).
61
+
Looking for a quick guide on building components? Check out [our Cheat Sheet](../resources/cheat-sheet.md#building-components).
Copy file name to clipboardExpand all lines: packages/web-components/fast-element/docs/guide/declaring-templates.md
+4-4
Original file line number
Diff line number
Diff line change
@@ -144,7 +144,7 @@ When binding to `class`, the underlying engine will not over-write classes added
144
144
145
145
**Example: Nullish value**
146
146
147
-
Some cases may occur where an attribute needs to have a value when used however not present if unused. These are different than boolean attributes by where their presence alone triggers their effect. In this situation a nullish value (`null` or `undefined`) may be provided so the attribute won't exist in that condition.
147
+
Some cases may occur where an attribute needs to have a value when used however not present if unused. These are different than boolean attributes by where their presence alone triggers their effect. In this situation, a nullish value (`null` or `undefined`) may be provided so the attribute won't exist in that condition.
@@ -218,13 +218,13 @@ The second example demonstrates an important characteristic of the templating en
218
218
It is during the `connectedCallback` phase of the Custom Element lifecycle that `FASTElement` creates templates and binds the resulting view. The creation of the template only occurs the first time the element is connected, while binding happens every time the element is connected (with unbinding happening during the `disconnectedCallback` for symmetry).
219
219
220
220
:::note
221
-
In the future we're planning new optimizations that will enable us to safely determine when we do not need to unbind/rebind certain views.
221
+
In the future, we're planning new optimizations that will enable us to safely determine when we do not need to unbind/rebind certain views.
222
222
:::
223
223
224
224
In most cases, the template that `FASTElement` renders is determined by the `template` property of the Custom Element's configuration. However, you can also implement a method on your Custom Element class named `resolveTemplate()` that returns a template instance. If this method is present, it will be called during `connectedCallback` to obtain the template to use. This allows the element author to dynamically select completely different templates based on the state of the element at the time of connection.
225
225
226
-
In addition to dynamic template selection during the `connectedCallback`, the `$fastController` property of `FASTElement` enables dynamically changing the template at any time through setting the controller's `template` property to any valid template.
226
+
In addition to dynamic template selection during the `connectedCallback`, the `$fastController` property of `FASTElement` enables dynamically changing the template at any time by setting the controller's `template` property to any valid template.
227
227
228
228
:::tip
229
-
Check out [our Cheat Sheet](/docs/resources/cheat-sheet#bindings) for a quick guide on bindings.
229
+
Check out [our Cheat Sheet](../resources/cheat-sheet.md#bindings) for a quick guide on bindings.
Copy file name to clipboardExpand all lines: packages/web-components/fast-element/docs/guide/defining-elements.md
+2-2
Original file line number
Diff line number
Diff line change
@@ -58,7 +58,7 @@ export class NameTag extends FASTElement {
58
58
To add attributes to your HTML element, create properties decorated by the `@attr` decorator. All attributes defined this way will be automatically registered with the platform so that they can be updated through the browser's native `setAttribute` API as well as the property. You can optionally add a method with the naming convention *propertyName*Changed to your class (e.g. `greeting` and `greetingChanged()`), and this method will be called whenever your property changes, whether it changes through the property or the attribute API.
59
59
60
60
:::note
61
-
All properties decorated with `@attr` are also *observable*. See [observables and state](./observables-and-state) for information about how observables enable efficient rendering.
61
+
All properties decorated with `@attr` are also *observable*. See [observables and state](./observables-and-state.md) for information about how observables enable efficient rendering.
62
62
:::
63
63
64
64
By default, anything extending from `FASTElement` will automatically have a `ShadowRoot` attached in order to enable encapsulated rendering.
@@ -142,7 +142,7 @@ export class MyCounter extends FASTElement {
142
142
143
143
## The element lifecycle
144
144
145
-
All Web Components support a series of lifecycle events that you can tap into to execute custom code at specific points in time. `FASTElement` implements several of these callbacks automatically in order to enable features of its templating engine (described in [declaring templates](./declaring-templates)). However, you can override them to provide your own code. Here's an example of how you would execute custom code when your element is inserted into the DOM.
145
+
All Web Components support a series of lifecycle events that you can tap into to execute custom code at specific points in time. `FASTElement` implements several of these callbacks automatically in order to enable features of its templating engine (described in [declaring templates](./declaring-templates.md)). However, you can override them to provide your own code. Here's an example of how you would execute custom code when your element is inserted into the DOM.
146
146
147
147
**Example: Tapping into the Custom Element Lifecycle**
0 commit comments