BREAKING CHANGE: update eslint config to align with latest reqs (#5303)

* update eslint-config-rules and versions, fix fast-element lint errors

* fix fast-router lint issues

* fix foundation errors

* fix figma plugin lint errors

* fix react issues and disable ban types for empty object as its useful in tsx defs

* Change files

* temporary allow major version for eslint package

add js file override to eslint config (#5310)

* add js file override to eslint config

* deduplicate lockfile

* remove no-non-null-assertation and add noImplicitAny and strictPropertyInitialization to base tsconfig

* fix new errors in web utils

* turn off noImplicitAny and strictPropertyInitialization for fast-element due to errors

* turn off strictPropertyAssignment and noImplicitAny for fast-foundation tsconfig

* resolve certain no-non-null-assertion errors and disable others

* turn off noImplicitAny and strictPropertyInitialization for fast-components

* disable anchored region and palette

* resolve color constants, dsp, dialog issues

* turn off strictPropertyInitialization and noImplicitAny for fast-router

* turn off no-non-null-assertion in eslint

* turn off strictNullChecks, strictPropertyInitialization, and noImplicitAny in fast-colors

* update fast-react-wrapper

* Change files

* fixup web utilities dom typings

* fixup fast-web-utilities html spec files

* disable strict null checks due to numbers, rtl, and string test and fn issues

* fixup final react wrapper issues

* add types specifically for the test package

* fix figma plugin type issues

* ignore non-null errors for color in fast-color-explorer

* fix type error by casting due to implicit any

Author: chrisdholt

packages/utilities/fast-colors/tsconfig.json

@@ -1,6 +1,9 @@
 {
     "extends": "../../../tsconfig.json",
     "compilerOptions": {
+        "strictNullChecks": false,
+        "noImplicitAny": false,
+        "strictPropertyInitialization": false,
         "baseUrl": "."
     }
 }

packages/utilities/fast-eslint-rules/.eslintrc.js

@@ -4,17 +4,20 @@ module.exports = {
     plugins: ["@typescript-eslint", "import"],
     extends: [
         "eslint:recommended",
-        "plugin:react/recommended",
         "plugin:@typescript-eslint/eslint-recommended",
         "plugin:@typescript-eslint/recommended",
     ],
-    settings: {
-        react: {
-            version: "latest",
-        },
-    },
     rules: {
-        "@typescript-eslint/interface-name-prefix": ["error", { prefixWithI: "never" }],
+        "no-unused-vars": "off",
+        "no-extra-boolean-cast": "off",
+        "no-empty-function": "off",
+        "@typescript-eslint/no-empty-function": [
+            "error",
+            { allow: ["asyncMethods", "methods"] },
+        ],
+        "@typescript-eslint/no-use-before-define": "off",
+        "@typescript-eslint/typedef": "off",
+        "@typescript-eslint/explicit-function-return-type": "off",
         "max-len": ["error", 140],
         "import/order": "error",
         "sort-imports": [
@@ -25,16 +28,12 @@ module.exports = {
             },
         ],
         "comma-dangle": "off",
-        "@typescript-eslint/typedef": [
+        "@typescript-eslint/no-empty-interface": [
             "error",
             {
-                parameter: true,
-                propertyDeclaration: true,
-                memberVariableDeclaration: true,
-                variableDeclarationIgnoreFunction: true,
+                allowSingleExtends: true,
             },
         ],
-        "@typescript-eslint/explicit-function-return-type": "error",
         "@typescript-eslint/camelcase": "off",
         "@typescript-eslint/naming-convention": [
             "error",
@@ -53,13 +52,33 @@ module.exports = {
                 format: null, // disable for variable names because of our foo__expanded convention for JSS
                 // TODO: I think we can come up with a regex that ignores variables with __ in them
             },
+            {
+                selector: "interface",
+                format: ["PascalCase"],
+                custom: {
+                    regex: "^I[A-Z]",
+                    match: false,
+                },
+            },
         ],
         "@typescript-eslint/no-inferrable-types": "off",
         "no-prototype-builtins": "off",
         "no-fallthrough": "off",
         "no-unexpected-multiline": "off",
         "@typescript-eslint/no-unused-vars": ["warn", { args: "none" }],
-        "react/no-children-prop": "off",
         "@typescript-eslint/no-explicit-any": "off",
     },
+    overrides: [
+        {
+            files: ["**/*.js"],
+            extends: ["eslint:recommended"],
+            env: {
+                node: true,
+                "shared-node-browser": true,
+            },
+            rules: {
+                "@typescript-eslint/no-var-requires": "off",
+            },
+        },
+    ],
 };

packages/utilities/fast-eslint-rules/package.json

@@ -21,12 +21,14 @@
   },
   "main": ".eslintrc.js",
   "homepage": "https://github.com/Microsoft/fast-eslint-rules#readme",
+  "beachball": {
+    "disallowedChangeTypes": []
+  },
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "^2.23.0",
-    "@typescript-eslint/parser": "^2.23.0",
-    "eslint": "^6.8.0",
-    "eslint-plugin-import": "^2.20.1",
-    "eslint-plugin-react": "^7.19.0",
-    "typescript": "^3.9.0"
+    "@typescript-eslint/eslint-plugin": "^5.0.0",
+    "@typescript-eslint/parser": "^5.0.0",
+    "eslint": "^8.0.0",
+    "eslint-plugin-import": "^2.25.0",
+    "typescript": "~3.9.0 || ~4.3.5"
   }
 }

packages/utilities/fast-react-wrapper/.eslintrc.js

@@ -1,10 +1,3 @@
 module.exports = {
     extends: ["@microsoft/eslint-config-fast-dna", "prettier"],
-    rules: {
-        "no-extra-boolean-cast": "off",
-        "@typescript-eslint/no-use-before-define": "off",
-        "@typescript-eslint/typedef": "off",
-        "@typescript-eslint/explicit-function-return-type": "off",
-        "@typescript-eslint/no-non-null-assertion": "off",
-    },
 };