Upgrade to Java 11 and Spring 5 #1570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like the cleanest version of the update that I've seen done so far -- thank you for this. I think the CI needs to be updated to get Travis CI to run against Java 11 instead of Java 8. But other than that, have you tested and run this code? |
|
Hi @jricher, Thanks for the review. I have included the change to .travis.yml to point to oraclejdk11 from oraclejdk8. yes, I have tested and run the code and don't see any issues. We have also been running a port of the codebase with Spring 5 and Java 11 for several months now and haven't come across any problems. |
|
Thank you once again for this upgrade, hopefully this helps people running it on more updated systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to upgrade codebase from spring 4.X to spring 5.X and from Java8 to Java11. The overall project structure remains the same.
Please review and let me know if anything needs to be corrected. Thanks!