[dotnet] Fix Resharper code issues (pulumi#7178)

* Fix resharper code issues for language usage opportunities

* Fix resharper code issues for common practices and code improvements

* Fix resharper code issues for potential code quality issues

* Fix resharper code issues for redundancies in code

* Fix xunit test output

* Update changelog

* Fix resharper code issues for compiler warnings

* Fix resharper code issues for inconsistent naming

* Add resharper solution settings file

* Fix resharper code issues for potential code quality issues

* Fix resharper code issues for redundancies in code

* Fix resharper code issues for redundancies in symbol declarations

Author: gitfool

CHANGELOG_PENDING.md

@@ -1,5 +1,7 @@
 ### Improvements
 
+- [dotnet] Fix Resharper code issues.
+  [#7178](https://github.com/pulumi/pulumi/pull/7178)
 
 - [codegen] - Include properties with an underlying type of string on Go provider instances.
 

sdk/dotnet/Pulumi.Automation.Tests/CommandExceptionTests.cs

@@ -80,8 +80,9 @@ public async Task ConcurrentUpdateExceptionIsThrown()
                 var program = PulumiFn.Create(() =>
                 {
                     hitSemaphore = true;
+                    // ReSharper disable once AccessToDisposedClosure
                     semaphore.Wait();
-                    return new Dictionary<string, object?>()
+                    return new Dictionary<string, object?>
                     {
                         ["test"] = "doesnt matter",
                     };

sdk/dotnet/Pulumi.Automation.Tests/EventLogWatcherTests.cs

@@ -1,9 +1,9 @@
 // Copyright 2016-2021, Pulumi Corporation
 
+using System;
+using System.IO;
 using System.Threading;
 using System.Threading.Tasks;
-using System.IO;
-using System;
 using Pulumi.Automation.Events;
 using Xunit;
 
@@ -37,12 +37,7 @@ public async Task ReceivesManyBasicEvents()
         [Fact]
         public async Task PropagatesUserExceptionsToCaller()
         {
-            using var fx = new Fixture();
-
-            fx.Action = ev =>
-            {
-                throw new MyException();
-            };
+            using var fx = new Fixture { Action = ev => throw new MyException() };
 
             await fx.Write("{}");
 
@@ -62,7 +57,7 @@ public async Task PermitsUserInitiatedCancellation()
 
         private class MyException : Exception { }
 
-        private class Fixture : IDisposable
+        private sealed class Fixture : IDisposable
         {
             public int EventCounter;
             public string LogFileName { get; }

sdk/dotnet/Pulumi.Automation.Tests/LocalPulumiCmdTests.cs

@@ -2,10 +2,10 @@
 
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using System.Threading.Tasks;
-using Xunit;
 using Pulumi.Automation.Commands;
-using System.Linq;
+using Xunit;
 
 namespace Pulumi.Automation.Tests
 {
@@ -15,8 +15,8 @@ public class LocalPulumiCmdTests
         public async Task CheckVersionCommand()
         {
             var localCmd = new LocalPulumiCmd();
-            IDictionary<string, string?> extraEnv = new Dictionary<string, string?>();
-            IEnumerable<string> args = new string[]{ "version" };
+            var extraEnv = new Dictionary<string, string?>();
+            var args = new[] { "version" };
 
             var stdoutLines = new List<string>();
             var stderrLines = new List<string>();