-
Notifications
You must be signed in to change notification settings - Fork 15
Clarify values of AV1CodecConfigurationRecord fields. #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add text explicitly stating the values for twelve_bit, chroma_subsampling_x, chroma_subsampling_y, and chroma_sample_position when not present in the Sequence Header OBU. Closes #102
@VFR-maniac and @cconcolato ptal/thx! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a "Changes since v1.0.0" section.
There are no cases of absences of chroma_subsampling_x and chroma_subsampling_y at the current ver. of AV1 spec. It's for possible future versions? |
This wording is to handle the multiple cases where chroma_subsampling_x and chroma_subsampling_y have specified values but are not present in the Sequence Header OBU. |
Added in c18b35c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I wouldn't place the change log at the very beginning of the spec. I would put it last.
- Could you also add a "Last approved version" (or similar) at the top of the spec with a link to the v1.0.0 ?
- Shouldn't we add the "warning" back?
Done.
We don't have this hosted anywhere yet. The rawgit trick works with the v1.0.0 tag, so I used that.
Done |
Add text explicitly stating the values for twelve_bit,
chroma_subsampling_x, chroma_subsampling_y, and
chroma_sample_position when not present in the Sequence
Header OBU.
Closes #102