Skip to content

Conversation

@wantehchang
Copy link
Contributor

@wantehchang wantehchang commented Oct 11, 2022

In "their values SHALL match", change the word "match" to "equal (except for different binary representations and precision issues, see the second note below)".

Exchange METADATA_TYPE_HDR_CLL and METADATA_TYPE_HDR_MDCV so that they correspond to mdcv and clli in the right order.

Fix #138.


Preview | Diff

@wantehchang wantehchang force-pushed the issue-138-add-note-on-mdcv branch from e2892e7 to 97fdc16 Compare October 11, 2022 00:25
index.bs Outdated
<assert>The sample entry SHOULD contain a 'colr' box with a colour_type set to 'nclx'</assert>. <assert>If present, the values of colour_primaries, transfer_characteristics, and matrix_coefficients SHALL match the values given in the [=Sequence Header OBU=] (in the configOBUs field or in the associated samples) if the color_description_present_flag is set to 1</assert>. Similarly, <assert>the full_range_flag in the 'colr' box SHALL match the color_range flag in the [=Sequence Header OBU=]</assert>. <assert>When configOBUs does not contain a [=Sequence Header OBU=], this box with colour_type set to 'nclx' SHALL be present.</assert>

<assert>For sample entries corresponding to HDR content, the MasteringDisplayColourVolumeBox 'mdcv' and ContentLightLevelBox 'clli' SHOULD be present</assert>, and <assert>their values SHALL match the values contained in the [=Metadata OBUs=] of type METADATA_TYPE_HDR_CLL and METADATA_TYPE_HDR_MDCV, if present (in the configOBUs or in the samples)</assert>.
<assert>For sample entries corresponding to HDR content, the MasteringDisplayColourVolumeBox 'mdcv' and ContentLightLevelBox 'clli' SHOULD be present</assert>, and <assert>their values SHALL equal (except for different binary representations and precision issues, see the second note below) the values contained in the [=Metadata OBUs=] of type METADATA_TYPE_HDR_MDCV and METADATA_TYPE_HDR_CLL, if present (in the configOBUs or in the samples)</assert>.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cyril: Compared with #141 (which you reviewed), this PR changed the following:

equal (except for precision issues, see the second note below)

to:

equal (except for different binary representations and precision issues, see the second note below)

@cconcolato
Copy link
Collaborator

For sample entries corresponding to HDR content, the MasteringDisplayColourVolumeBox mdcv and ContentLightLevelBox clli SHOULD be present , and their values SHALL match equal (except for different binary representations and precision issues, see the second note below) the values contained in the Metadata OBUs of type METADATA_TYPE_HDR_CLL METADATA_TYPE_HDR_MDCV and METADATA_TYPE_HDR_MDCV, METADATA_TYPE_HDR_CLL, if present (in the configOBUs or in the samples) .

change it to:

For sample entries corresponding to HDR content, the following applies:

  • the ContentLightLevelBox clli SHOULD be present. Its values SHALL equal the values contained in the Metadata OBUs of type METADATA_TYPE_HDR_CLL, if present (in the configOBUs or in the samples) .
  • the MasteringDisplayColourVolumeBox mdcv SHOULD be present. Its decoded values SHALL equal (except for precision issues, see the second note below) the decoded values contained in the Metadata OBUs of type METADATA_TYPE_HDR_MDCV, METADATA_TYPE_HDR_CLL, if present (in the configOBUs or in the samples) .

Split the requirements on 'clli' and 'mdcv' into separate list items so
that we can state the more complicated requirements that only apply to
'mdcv'.

Fix AOMediaCodec#138.
@wantehchang wantehchang force-pushed the issue-138-add-note-on-mdcv branch from 97fdc16 to 1e10cdb Compare December 12, 2022 19:23
@wantehchang
Copy link
Contributor Author

Cyril: I made the changes you suggested. Please review.

I made minor edits to your suggestion, on capitalization, fixing an error, and removing extra spaces at the end of sentences.

@wantehchang wantehchang merged commit c870786 into AOMediaCodec:main Jan 23, 2023
@wantehchang wantehchang deleted the issue-138-add-note-on-mdcv branch January 23, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarifications on mdcv box

2 participants