Make «use 5.036;» respect -X #21431
Merged
Make «use 5.036;» respect -X #21431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Th change looks right, but I think it could use a test. |
rwp0
approved these changes
Aug 29, 2023
Contributor
|
Code looks good but I agree a test would be useful. Do we not have any tests of |
Contributor
Author
|
No, and more disconcertingly neither does |
Contributor
Author
|
Added tests. |
perl's -X flag disables all warnings globally, but «use 5.036» didn't respect that until now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perl's -X flag disables all warnings globally, but «use 5.036» didn't respect that until now.
This fixes #21427