Build Site and fix 1288 #1289
Merged
Build Site and fix 1288 #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstamas
reviewed
Mar 13, 2025
cstamas
reviewed
Mar 13, 2025
.github/workflows/early-access.yaml
Outdated
|
|
||
| - name: 'Run default (non-native) build' | ||
| run: ./mvnw verify -Dmrm=false -V -B -ntp -e -s .mvn/release-settings.xml | ||
| run: ./mvnw verify site -Dmrm=false -V -B -ntp -e -s .mvn/release-settings.xml |
Contributor
There was a problem hiding this comment.
Yes, maybe another job would be better specifically for the site.
Contributor
Author
There was a problem hiding this comment.
Moved it to another Job
044be95 to
3ea19ee
Compare
as the purpose of CI is to reveal errors early (in particular on forks). This contributes to fix apache#1288 but might be helpful for other changes as well. Otherwise this commit should be stripped from the build before merging
by switching to the latest Maven Fluido Skin which is compatible with the currently used M-Site-P (3.21.0).
10f45af to
e435124
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides a fix for #1288 the change also contains
mvn ... site) to detect such problems early in the futureThe latter leads to CI builds for each development change (which is a major purpose of an automatic build and helps in particular for forks/new contributors who cannot issue a automatic build by creating a PR). Having said that, the respective commit could be dropped if there is a good reason not to follow this practice.