Skip to content

Adding editorconfig setting for IDE hints #10855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
willbarrett merged 2 commits into from
Sep 14, 2020
Merged

Adding editorconfig setting for IDE hints #10855

willbarrett merged 2 commits into from
Sep 14, 2020

Conversation

@zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Sep 14, 2020

SUMMARY

  • When editing Python files, always forget the longest character limit in CI, add editconfig configuration, can let IDE/Editor remind instead of wait until CI is executed.
  • When editing frontend files, also need remind indentation is 2.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

ktmud
ktmud approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@willbarrett willbarrett merged commit a324fbd into apache:master Sep 14, 2020
@zhaoyongjie zhaoyongjie deleted the editor_config branch September 21, 2020 14:42
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@zhaoyongjie @auxten
Adding editorconfig setting for IDE hints (apache#10855)
14ed4a8 
* Adding editorconfig setting for IDE hints

* adding license to new file
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 First shipped in 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktmud ktmud ktmud approved these changes

@willbarrett willbarrett willbarrett approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.38.0 First shipped in 0.38.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhaoyongjie @ktmud @willbarrett @mistercrunch