chore: upgrade lerna and use nx #24896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3553e53.
corymhall
commented
Apr 11, 2023
| "lerna": "^4.0.0", | ||
| "npmClient": "yarn", | ||
| "useWorkspaces": true, | ||
| "packages": [ |
Contributor
Author
There was a problem hiding this comment.
For some reason if you don't specify each package then lerna can't figure it out. I think it might be because we have packages with the same name in different locations.
Contributor
Author
|
I ran this through the test pipeline and the build passed. |
MrArnoldPalmer
approved these changes
Apr 13, 2023
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
comcalvi
approved these changes
Apr 13, 2023
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating lerna to the latest version which now uses
nxunder the hood. Apart from just updating the version, this also allows us to take advantage of nx caching. For now this has only been enabled locally.I'm not 100% sure about the
nxconfiguration since our repo is a little weird, but I've been running locally with this configuration for probably 6 months and it has worked fine for me.Side note - the repo restructure has caused some weirdness with our tests. I had to make some updates to existing tests, and I do not know why.
Closes #.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license