Skip to content

Conversation

@arendjr
Copy link
Contributor

@arendjr arendjr commented Apr 18, 2025

Summary

Follow-up on #5533 . Updated crates annotations to enforce the use of Self, and updated part of the codegen/made some exclusions for the rest.

Thanks to @adamnemecek for the suggestion and the reference to start on this.

Test Plan

CI should remain green.

@arendjr arendjr requested review from a team April 18, 2025 08:02
@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools A-LSP Area: language server protocol L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS L-JSON Language: JSON and super languages A-Diagnostic Area: diagnostocis L-HTML Language: HTML and super languages L-Grit Language: GritQL labels Apr 18, 2025
@ematipico
Copy link
Member

@arendjr if possible, can you cherry-pick @adamnemecek 's commit, so they will appear in the commit history as a contributor?

@arendjr
Copy link
Contributor Author

arendjr commented Apr 18, 2025

I didn't do a cherry-pick to avoid the merge errors, but I've amended the commit with a Co-authored-by line, so now we both show up :)

@arendjr arendjr merged commit d7dff5c into biomejs:main Apr 18, 2025
12 of 13 checks passed
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 18, 2025

CodSpeed Performance Report

Merging #5699 will not alter performance

Comparing arendjr:use-self (d2842c5) with main (f3c34de)

Summary

✅ 95 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLI Area: CLI A-Core Area: core A-Diagnostic Area: diagnostocis A-Formatter Area: formatter A-Linter Area: linter A-LSP Area: language server protocol A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-CSS Language: CSS L-Grit Language: GritQL L-HTML Language: HTML and super languages L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants