docs: Getting started rewrite #16497
Conversation
|
💻 Deploy preview available: |
|
@JStickler, for some reason, the tests keep failing on this one. We are ready for review, happy to discuss these changes on our call together as it was quite a big change to the getting started guide. |
JStickler
left a comment
There was a problem hiding this comment.
Only made it through the docs before I ran out of time. I'll look at the KillerCoda tomorrow.
Co-authored-by: J Stickler <[email protected]> Signed-off-by: Jay Clifford <[email protected]>
|
Aaah thanks @JStickler! All changes are accepted, and the killercoda has been updated for your testing. |
JStickler
left a comment
There was a problem hiding this comment.
Made it through both the docs/local install and the Killercoda today.
Co-authored-by: J Stickler <[email protected]> Signed-off-by: Jay Clifford <[email protected]>
Co-authored-by: J Stickler <[email protected]> Signed-off-by: Jay Clifford <[email protected]>
|
Hey @JStickler, just accepted your amendments. Will work through the rest manually :) |
JStickler
left a comment
There was a problem hiding this comment.
[docs team] Something's still off, I'm getting the Explore menu instead of the new Drilldown menu. =(
|
Hey @JStickler, so i think i caught all the changes you made before we moved the tutorial so hopefully I caught them all. I have also fixed the Killercoda to the right URL and updated the Grafana version which should fix the old explore UI menu to Drill down. You just might need to do a full docker compose down and then up again to see it: |
JStickler
left a comment
There was a problem hiding this comment.
[docs team] I tried running through the killercoda, but it's not working. Maybe it's because the PR is so old, and we've had a new release?
Co-authored-by: J Stickler <[email protected]> Signed-off-by: Jay Clifford <[email protected]>
Co-authored-by: J Stickler <[email protected]> Signed-off-by: Jay Clifford <[email protected]>
|
That should be us up and running: https://killercoda.com/grafana-dev-testing/course/loki/loki-getting-started-tutorial with the latest changes :) |
JStickler
left a comment
There was a problem hiding this comment.
[docs team] Yay, finally got the docker environment fixed, and I see Drilldown Logs, not Explore Logs.
Co-authored-by: J Stickler <[email protected]> Signed-off-by: Jay Clifford <[email protected]>
There was a problem hiding this comment.
[docs team] Ran through the Killercoda today, everything looked good. I'm going to merge a few more typos I found and approve this PR. But I want to wait to merge this until the engineering team finishes backporting all the CI updates from this week. So look for this to merge late Friday or possibly Monday. Yay, we finally got this one over the finish line!
Last couple of spelling errors. Signed-off-by: J Stickler <[email protected]>
Signed-off-by: Jay Clifford <[email protected]> Signed-off-by: J Stickler <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit e89fd41)
What this PR does / why we need it:
With the focus change to two deployment modes, Monolthic and Microservice, it was time to refresh the quick start guide to Loki. This incorporates much of the same flavour as the original:
But includes newer features:
Aswell as adding the Carnivouse Greehouse example to provide an interactive method to understanding LogQL queries.
Killercoda sample found here: https://killercoda.com/grafana-dev-testing/course/workshops/course-tracker-test
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR