Skip to content

feat: create a docker environment for flux release #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

rockstar
Copy link
Contributor

This patch adds the start of a Dockerfile to be used for releasing flux,
complete with cross compilers for all triples except
x86_64-apple-darwin and x86_64-pc-windows-gnu, which require a bit
more setup.

The intent here is to start with the Dockerfile, add support for using
pkg-config (and ditching flux-config), and being able to build flux,
including libflux, for any architecture by invoking go build. This
docker image will be used similar to Dockerfile_build is converted
into quay.io/influxdb/flux-build.

This patch adds the start of a Dockerfile to be used for releasing flux,
complete with cross compilers for all triples except
`x86_64-apple-darwin` and `x86_64-pc-windows-gnu`, which require a bit
more setup.

The intent here is to start with the Dockerfile, add support for using
`pkg-config` (and ditching `flux-config`), and being able to build flux,
including `libflux`, for any architecture by invoking `go build`. This
docker image will be used similar to `Dockerfile_build` is converted
into `quay.io/influxdb/flux-build`.
@rockstar rockstar requested a review from a team February 11, 2020 21:41
@ghost ghost requested review from adrian-thurston and removed request for a team February 11, 2020 21:41
@codecov-io
Copy link

Codecov Report

Merging #2514 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2514   +/-   ##
=======================================
  Coverage   52.97%   52.97%           
=======================================
  Files         300      300           
  Lines       40509    40509           
=======================================
  Hits        21458    21458           
  Misses      16824    16824           
  Partials     2227     2227

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bef3228...a1a3eac. Read the comment docs.

@rockstar rockstar merged commit 54e4797 into influxdata:master Feb 12, 2020
@rockstar rockstar deleted the release-dockerfile branch February 12, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants