refactor(lang): remove dependency on runtime #2596
Merged
+152
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lang package has been refactored to refer to the runtime using the `flux.Runtime` interface instead of direct references. This prevents it from have a dependency on the runtime and allows the structs to be used without incurring a dependency on the runtime. The `flux.Runtime` interface has been created to facilitate access to the runtime. It is a wrapper around the existing runtime struct that is in the `runtime` package. The `complete` package has also had its reference to the runtime removed. It was only used by one convenience method so that method has been removed.
ddf54dd to
f86b4a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lang package has been refactored to refer to the runtime using the
flux.Runtimeinterface instead of direct references. This prevents itfrom have a dependency on the runtime and allows the structs to be used
without incurring a dependency on the runtime.
The
flux.Runtimeinterface has been created to facilitate access tothe runtime. It is a wrapper around the existing runtime struct that is
in the
runtimepackage.The
completepackage has also had its reference to the runtimeremoved. It was only used by one convenience method so that method has
been removed.
Fixes #2595.
Done checklist