refactor: replace builtin package with fluxinit/static #3304
+65
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9e391a to
8b49502
Compare
nathanielc
approved these changes
Nov 4, 2020
| @@ -1,13 +0,0 @@ | |||
| // Package builtin contains all packages related to Flux built-ins are imported and initialized. | |||
| // This should only be imported from main or test packages. | |||
| // It is a mistake to import it from any other package. | |||
There was a problem hiding this comment.
Could you add a similar comment to the new static package?
There was a problem hiding this comment.
Oh yes thanks for catching that.
|
Also I expect you will have to create equivalent |
Yup, will need that too. |
ec6ebb7 to
c8e0f1e
Compare
A static initialization is not desirable in the main binaries, as it forces all paths of code to init, but it is still useful in tests. It allows static intialization to be performed once for all tests and eliminates the need to always add the FluxInit call. Added a fluxinit/static package that calls fluxinit.FluxInit() to replace the builtin package. This hides the nature of the initialization and makes it clear that it is mandatory initialization code.
c8e0f1e to
dc0ec0d
Compare
Codecov Report
@@ Coverage Diff @@
## master #3304 +/- ##
==========================================
+ Coverage 49.34% 49.36% +0.01%
==========================================
Files 351 351
Lines 36393 36393
==========================================
+ Hits 17957 17964 +7
+ Misses 15913 15907 -6
+ Partials 2523 2522 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A static initialization is not desirable in the main binaries, as it forces all
paths of code to init, but it is still useful in tests. It allows static
intialization to be performed once for all tests and eliminates the need to
always add the FluxInit call. Added a fluxinit/static package that calls
fluxinit.FluxInit() to replace the builtin package. This hides the nature of
the initialization and makes it clear that it is mandatory initialization code.