feat(cmd): merge and replace the main flux cli with the alternate one #4611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
approved these changes
Mar 29, 2022
Contributor
nathanielc
left a comment
There was a problem hiding this comment.
LGTM but I expect there are a few places in CI that need updating. The checkfmt step is failing as well as I expect the fluxdoc step to fail since it explicitly installs the internal/cmd. A simple fix to the Makefile should be enough.
Approving as I don't need to re-review once CI is happy.
This merges the fmt and test commands into the flux cli that's been getting tested in `internal/cmd` and then it promotes the one in `internal/cmd` to `cmd`. This removes the `execute` and `repl` commands and instead makes those the default. When no parameters are used, the `repl` is started. When a parameter is used, the script is executed. In addition, the script is executed in a normal context rather than hacking it through the repl. This should make the results of running a script from the CLI be more similar to if the script were run in InfluxDB.
5e87328 to
9a9d15c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the fmt and test commands into the flux cli that's been
getting tested in
internal/cmdand then it promotes the one ininternal/cmdtocmd.This removes the
executeandreplcommands and instead makes thosethe default. When no parameters are used, the
replis started. When aparameter is used, the script is executed. In addition, the script is
executed in a normal context rather than hacking it through the repl.
This should make the results of running a script from the CLI be more
similar to if the script were run in InfluxDB.
Fixes #4606.
Done checklist