Skip to content

Conversation

@Marwes
Copy link
Contributor

@Marwes Marwes commented Sep 2, 2022

Before they would be displayed as the zero-value of whatever type the column is which is rather confusing. Now it is left empty instead (or should we display <nil> or something instead?)

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

@Marwes Marwes marked this pull request as ready for review September 2, 2022 15:20
@Marwes Marwes requested a review from a team as a code owner September 2, 2022 15:20
@Marwes Marwes requested review from wolffcm and removed request for a team September 2, 2022 15:20
Copy link

@wolffcm wolffcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any acceptance tests for diff? Maybe not I guess.

Thanks for doing this!

@Marwes Marwes merged commit 379de99 into master Sep 7, 2022
@Marwes Marwes deleted the display_null branch September 7, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants