chore(a11y-testing): Remove dependency on `keyboard-keys` #19840

ling1726 · 2021-09-16T22:43:41Z

Pull request checklist

Addresses an existing issue: Fixes partially react-components versioning and release cycle #19106
Include a change request file using $ yarn change

Description of changes

Clean up dependency separation between v9 and non-v9 packages in the
repo.

The usage of the keyboard-keys package was fairly limited and the string keys are self explanatory. The keyboard-keys package was intended to used in the web platform to reduce bundle size from duplicated strings.

Focus areas to test

(optional)

Clean up dependency separation between v9 and non-v9 packages in the repo

codesandbox-ci · 2021-09-16T22:49:32Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e30e965:

Sandbox	Source
Fluent UI React Starter	Configuration

size-auditor · 2021-09-16T22:54:06Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d05b3db7f100423b47d782ddf457252171395de6 (build)

fabricteam · 2021-09-16T22:58:20Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`react-button` Button	`22.932 kB` `6.984 kB`
`react-button` CompoundButton	`28.215 kB` `7.834 kB`
`react-button` MenuButton	`24.733 kB` `7.546 kB`
`react-button` ToggleButton	`32.527 kB` `7.601 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`163.935 kB` `46.761 kB`
`react-components` react-components: FluentProvider & webLightTheme	`35.75 kB` `11.392 kB`
`react-link` Link	`13.718 kB` `5.66 kB`

_{🤖 This report was generated against d05b3db7f100423b47d782ddf457252171395de6}

fabricteam · 2021-09-16T23:12:42Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1024	1003	5000
BaseButton	mount	987	985	5000
Breadcrumb	mount	2751	2803	1000
ButtonNext	mount	477	492	5000
Checkbox	mount	1672	1699	5000
CheckboxBase	mount	1401	1448	5000
ChoiceGroup	mount	5158	5191	5000
ComboBox	mount	1049	1092	1000
CommandBar	mount	10574	10661	1000
ContextualMenu	mount	6927	6758	1000
DefaultButton	mount	1244	1208	5000
DetailsRow	mount	3937	3962	5000
DetailsRowFast	mount	4019	4045	5000
DetailsRowNoStyles	mount	3801	3834	5000
Dialog	mount	2628	2523	1000
DocumentCardTitle	mount	155	154	1000
Dropdown	mount	3509	3495	5000
FluentProviderNext	mount	7229	7456	5000
FluentProviderWithTheme	mount	346	340	10
FluentProviderWithTheme	virtual-rerender	94	98	10
FluentProviderWithTheme	virtual-rerender-with-unmount	495	478	10
FocusTrapZone	mount	1908	1905	5000
FocusZone	mount	1880	1833	5000
IconButton	mount	1914	1902	5000
Label	mount	368	367	5000
Layer	mount	3143	3228	5000
Link	mount	498	518	5000
MakeStyles	mount	1898	1880	50000
MenuButton	mount	1610	1550	5000
MessageBar	mount	2104	2154	5000
Nav	mount	3609	3568	1000
OverflowSet	mount	1160	1161	5000
Panel	mount	2498	2441	1000
Persona	mount	904	910	1000
Pivot	mount	1498	1519	1000
PrimaryButton	mount	1368	1377	5000
Rating	mount	8440	8599	5000
SearchBox	mount	1465	1447	5000
Shimmer	mount	2745	2856	5000
Slider	mount	2068	2099	5000
SpinButton	mount	5322	5373	5000
Spinner	mount	444	436	5000
SplitButton	mount	3349	3303	5000
Stack	mount	534	529	5000
StackWithIntrinsicChildren	mount	1723	1720	5000
StackWithTextChildren	mount	5118	5128	5000
SwatchColorPicker	mount	11223	11050	5000
Tabs	mount	1515	1483	1000
TagPicker	mount	2735	2829	5000
TeachingBubble	mount	13710	13905	5000
Text	mount	487	483	5000
TextField	mount	1543	1537	5000
ThemeProvider	mount	1285	1296	5000
ThemeProvider	virtual-rerender	653	650	5000
ThemeProvider	virtual-rerender-with-unmount	2065	2087	5000
Toggle	mount	889	929	5000
buttonNative	mount	123	113	5000