fix typo in `specs/Datepicker.md` #29656

Bitnagar · 2023-10-26T11:10:41Z

This PR fixes a typo in specs/Datepicker.md

recomendation -> recommendation

No other changes.

codesandbox-ci · 2023-10-26T11:23:45Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b08a0e3:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

layershifter · 2023-10-30T12:55:21Z

/azp run

azure-pipelines · 2023-10-30T12:55:51Z

Azure Pipelines successfully started running 4 pipeline(s).

fabricteam · 2023-10-30T13:05:29Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	635	650	5000
Button	mount	319	306	5000
Field	mount	1137	1114	5000
FluentProvider	mount	710	723	5000
FluentProviderWithTheme	mount	78	86	10
FluentProviderWithTheme	virtual-rerender	68	58	10
FluentProviderWithTheme	virtual-rerender-with-unmount	82	70	10
MakeStyles	mount	861	865	50000
Persona	mount	1805	1724	5000
SpinButton	mount	1355	1379	5000

fabricteam · 2023-10-30T13:10:00Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2023-10-30T13:11:11Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AttachmentMinimalPerf.default	86	76	1.13:1
MenuMinimalPerf.default	520	479	1.09:1
ItemLayoutMinimalPerf.default	741	699	1.06:1
ListNestedPerf.default	330	310	1.06:1
ChatWithPopoverPerf.default	199	189	1.05:1
HeaderMinimalPerf.default	211	201	1.05:1
GridMinimalPerf.default	191	184	1.04:1
LayoutMinimalPerf.default	202	194	1.04:1
TextMinimalPerf.default	201	194	1.04:1
BoxMinimalPerf.default	204	199	1.03:1
ButtonSlotsPerf.default	314	305	1.03:1
FlexMinimalPerf.default	156	151	1.03:1
HeaderSlotsPerf.default	466	453	1.03:1
LabelMinimalPerf.default	224	217	1.03:1
ListMinimalPerf.default	307	299	1.03:1
SegmentMinimalPerf.default	200	194	1.03:1
IconMinimalPerf.default	386	374	1.03:1
ButtonMinimalPerf.default	86	84	1.02:1
CarouselMinimalPerf.default	264	260	1.02:1
CheckboxMinimalPerf.default	1143	1124	1.02:1
PortalMinimalPerf.default	88	86	1.02:1
SliderMinimalPerf.default	760	745	1.02:1
TooltipMinimalPerf.default	1290	1269	1.02:1
TreeMinimalPerf.default	487	479	1.02:1
TreeWith60ListItems.default	91	89	1.02:1
ChatMinimalPerf.default	442	438	1.01:1
DropdownManyItemsPerf.default	386	383	1.01:1
MenuButtonMinimalPerf.default	959	954	1.01:1
RadioGroupMinimalPerf.default	259	257	1.01:1
StatusMinimalPerf.default	395	392	1.01:1
TableMinimalPerf.default	234	232	1.01:1
CustomToolbarPrototype.default	1477	1466	1.01:1
ToolbarMinimalPerf.default	523	519	1.01:1
AnimationMinimalPerf.default	296	296	1:1
AttachmentSlotsPerf.default	657	659	1:1
DatepickerMinimalPerf.default	3534	3546	1:1
DialogMinimalPerf.default	444	443	1:1
ListCommonPerf.default	382	382	1:1
TextAreaMinimalPerf.default	284	283	1:1
ButtonOverridesMissPerf.default	639	648	0.99:1
DropdownMinimalPerf.default	1416	1429	0.99:1
EmbedMinimalPerf.default	1870	1885	0.99:1
ReactionMinimalPerf.default	206	208	0.99:1
RefMinimalPerf.default	107	108	0.99:1
SplitButtonMinimalPerf.default	2216	2238	0.99:1
TableManyItemsPerf.default	1111	1123	0.99:1
ChatDuplicateMessagesPerf.default	150	153	0.98:1
ImageMinimalPerf.default	211	216	0.98:1
PopupMinimalPerf.default	346	353	0.98:1
ProviderMergeThemesPerf.default	637	651	0.98:1
FormMinimalPerf.default	223	229	0.97:1
ListWith60ListItems.default	359	371	0.97:1
SkeletonMinimalPerf.default	192	198	0.97:1
DividerMinimalPerf.default	207	215	0.96:1
RosterPerf.default	1554	1611	0.96:1
AvatarMinimalPerf.default	98	103	0.95:1
ProviderMinimalPerf.default	193	203	0.95:1
CardMinimalPerf.default	301	320	0.94:1
AlertMinimalPerf.default	145	156	0.93:1
VideoMinimalPerf.default	428	460	0.93:1
InputMinimalPerf.default	508	555	0.92:1
LoaderMinimalPerf.default	186	203	0.92:1
AccordionMinimalPerf.default	80	88	0.91:1

fabricteam · 2023-10-30T13:14:11Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2023-10-30T13:15:21Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `330 B`
`global-context` createContextSelector	`537 B` `342 B`
`priority-overflow` createOverflowManager	`4.341 kB` `1.81 kB`
`react-accordion` Accordion (including children components)	`92.983 kB` `28.418 kB`
`react-alert` Alert	`84.293 kB` `23.456 kB`
`react-avatar` Avatar	`50.534 kB` `15.923 kB`
`react-avatar` AvatarGroup	`20.064 kB` `7.894 kB`
`react-avatar` AvatarGroupItem	`65.19 kB` `20.259 kB`
`react-badge` Badge	`27.264 kB` `8.808 kB`
`react-badge` CounterBadge	`28.165 kB` `9.101 kB`
`react-badge` PresenceBadge	`25.67 kB` `9.313 kB`
`react-button` Button	`40.074 kB` `11.292 kB`
`react-button` CompoundButton	`47.43 kB` `12.787 kB`
`react-button` MenuButton	`44.848 kB` `12.668 kB`
`react-button` SplitButton	`52.862 kB` `14.254 kB`
`react-button` ToggleButton	`57.122 kB` `13.194 kB`
`react-calendar-compat` Calendar Compat	`141.324 kB` `36.821 kB`
`react-card` Card - All	`92.955 kB` `26.977 kB`
`react-card` Card	`87.781 kB` `25.462 kB`
`react-card` CardFooter	`13.423 kB` `5.481 kB`
`react-card` CardHeader	`15.666 kB` `6.235 kB`
`react-card` CardPreview	`14.374 kB` `5.854 kB`
`react-checkbox` Checkbox	`37.505 kB` `12.327 kB`
`react-combobox` Combobox (including child components)	`92.033 kB` `30.008 kB`
`react-combobox` Dropdown (including child components)	`90.475 kB` `29.668 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`70.002 kB` `20.161 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`207.417 kB` `59.289 kB`
`react-components` react-components: FluentProvider & webLightTheme	`42.286 kB` `14 kB`
`react-datepicker-compat` DatePicker Compat	`212.494 kB` `59.326 kB`
`react-dialog` Dialog (including children components)	`94.473 kB` `28.28 kB`
`react-divider` Divider	`21.179 kB` `7.839 kB`
`react-field` Field	`22.788 kB` `8.639 kB`
`react-image` Image	`16.096 kB` `6.317 kB`
`react-infobutton` InfoButton	`130.729 kB` `41.194 kB`
`react-infobutton` InfoLabel	`134.413 kB` `42.351 kB`
`react-input` Input	`27.247 kB` `9.194 kB`
`react-jsx-runtime` Classic Pragma	`1.049 kB` `531 B`
`react-jsx-runtime` JSX Dev Runtime	`4.14 kB` `1.741 kB`
`react-jsx-runtime` JSX Runtime	`4.734 kB` `1.983 kB`
`react-label` Label	`14.508 kB` `5.857 kB`
`react-link` Link	`17.4 kB` `6.977 kB`
`react-menu` Menu (including children components)	`140.176 kB` `43.004 kB`
`react-menu` Menu (including selectable components)	`142.862 kB` `43.51 kB`
`react-message-bar` MessageBar (all components)	`25.54 kB` `9.102 kB`
`react-overflow` hooks only	`12.598 kB` `4.754 kB`
`react-persona` Persona	`57.425 kB` `17.798 kB`
`react-popover` Popover	`119.46 kB` `37.714 kB`
`react-portal` Portal	`12.4 kB` `4.541 kB`
`react-portal-compat` PortalCompatProvider	`6.651 kB` `2.252 kB`
`react-positioning` usePositioning	`25.305 kB` `9.162 kB`
`react-progress` ProgressBar	`17.788 kB` `6.986 kB`
`react-provider` FluentProvider	`22.831 kB` `8.429 kB`
`react-radio` Radio	`31.266 kB` `10.267 kB`
`react-radio` RadioGroup	`15.704 kB` `6.35 kB`
`react-select` Select	`28.968 kB` `10.269 kB`
`react-slider` Slider	`38.349 kB` `12.595 kB`
`react-spinbutton` SpinButton	`37.133 kB` `11.856 kB`
`react-spinner` Spinner	`23.762 kB` `8.556 kB`
`react-switch` Switch	`33.731 kB` `10.899 kB`
`react-table` DataGrid	`157.084 kB` `43.906 kB`
`react-table` Table (Primitives only)	`43.941 kB` `13.76 kB`
`react-table` Table as DataGrid	`130.165 kB` `35.174 kB`
`react-table` Table (Selection only)	`75.777 kB` `20.477 kB`
`react-table` Table (Sort only)	`74.384 kB` `20.075 kB`
`react-tags` InteractionTag	`15.618 kB` `6.152 kB`
`react-tags` Tag	`30.341 kB` `9.505 kB`
`react-tags` TagGroup	`73.816 kB` `22.097 kB`
`react-text` Text - Default	`17.065 kB` `6.645 kB`
`react-text` Text - Wrappers	`20.237 kB` `6.965 kB`
`react-textarea` Textarea	`31.306 kB` `10.549 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`34.611 kB` `7.295 kB`
`react-theme` Teams: Light theme	`19.282 kB` `5.486 kB`
`react-toast` Toast (including Toaster)	`92.725 kB` `27.876 kB`
`react-tooltip` Tooltip	`52.466 kB` `18.466 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against e280d28e27008ece218321f39466c4400faaf8b3}

size-auditor · 2023-10-30T13:16:01Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e280d28e27008ece218321f39466c4400faaf8b3 (build)

fabricteam · 2023-10-30T13:18:42Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2023-10-30T13:24:11Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	636	623	5000
Breadcrumb	mount	1644	1642	1000
Checkbox	mount	1683	1679	5000
CheckboxBase	mount	1476	1487	5000
ChoiceGroup	mount	2923	2982	5000
ComboBox	mount	667	684	1000
CommandBar	mount	6185	6064	1000
ContextualMenu	mount	11879	11609	1000
DefaultButton	mount	746	745	5000
DetailsRow	mount	2191	2152	5000
DetailsRowFast	mount	2159	2178	5000
DetailsRowNoStyles	mount	2021	1961	5000
Dialog	mount	2641	2621	1000
DocumentCardTitle	mount	223	214	1000
Dropdown	mount	1957	1962	5000
FocusTrapZone	mount	1114	1129	5000
FocusZone	mount	1084	1080	5000
GroupedList	mount	40989	40951	2
GroupedList	virtual-rerender	19789	19777	2
GroupedList	virtual-rerender-with-unmount	49929	50677	2
GroupedListV2	mount	228	227	2
GroupedListV2	virtual-rerender	205	218	2
GroupedListV2	virtual-rerender-with-unmount	229	229	2
IconButton	mount	1055	1091	5000
Label	mount	335	338	5000
Layer	mount	2684	2701	5000
Link	mount	380	394	5000
MenuButton	mount	951	939	5000
MessageBar	mount	21222	21247	5000
Nav	mount	1940	1961	1000
OverflowSet	mount	769	772	5000
Panel	mount	2037	1790	1000
Persona	mount	733	768	1000
Pivot	mount	864	860	1000
PrimaryButton	mount	841	827	5000
Rating	mount	4629	4592	5000
SearchBox	mount	907	929	5000
Shimmer	mount	1887	1863	5000
Slider	mount	1344	1308	5000
SpinButton	mount	2865	2929	5000
Spinner	mount	383	390	5000
SplitButton	mount	1842	1829	5000
Stack	mount	405	412	5000
StackWithIntrinsicChildren	mount	869	865	5000
StackWithTextChildren	mount	2645	2607	5000
SwatchColorPicker	mount	6074	6112	5000
TagPicker	mount	1493	1504	5000
Text	mount	378	369	5000
TextField	mount	940	927	5000
ThemeProvider	mount	827	836	5000
ThemeProvider	virtual-rerender	584	582	5000
ThemeProvider	virtual-rerender-with-unmount	1284	1254	5000
Toggle	mount	606	617	5000
buttonNative	mount	196	198	5000

khmakoto · 2023-10-30T19:28:28Z

/azp run Fluent UI React - PR and CI

azure-pipelines · 2023-10-30T19:28:39Z

Azure Pipelines successfully started running 1 pipeline(s).

khmakoto · 2023-10-30T19:54:04Z

/azp run Fluent UI React - Perf-Test

azure-pipelines · 2023-10-30T19:54:14Z

Azure Pipelines successfully started running 1 pipeline(s).

khmakoto · 2023-10-30T21:56:16Z

/azp run SizeAuditor

azure-pipelines · 2023-10-30T21:56:23Z

No pipelines are associated with this pull request.

khmakoto · 2023-10-31T20:55:55Z

/azp run

azure-pipelines · 2023-10-31T20:56:18Z

Azure Pipelines successfully started running 4 pipeline(s).

fix typo in Datepicker.md

16510a4

Bitnagar requested a review from a team as a code owner October 26, 2023 11:10

Merge branch 'master' into patch-1

283ff6d

khmakoto approved these changes Oct 27, 2023

View reviewed changes

Merge branch 'master' into patch-1

3d20af7

layershifter approved these changes Oct 30, 2023

View reviewed changes

layershifter enabled auto-merge (squash) October 30, 2023 11:15

Merge branch 'master' into patch-1

78e6346

Merge branch 'master' into patch-1

b08a0e3

layershifter merged commit c430734 into microsoft:master Oct 31, 2023

fix typo in specs/Datepicker.md #29656

fix typo in specs/Datepicker.md #29656

Uh oh!

Conversation

Bitnagar commented Oct 26, 2023

Uh oh!

codesandbox-ci bot commented Oct 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

layershifter commented Oct 30, 2023

Uh oh!

azure-pipelines bot commented Oct 30, 2023

Uh oh!

fabricteam commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUIV0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

size-auditor bot commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

khmakoto commented Oct 30, 2023

Uh oh!

azure-pipelines bot commented Oct 30, 2023

Uh oh!

khmakoto commented Oct 30, 2023

Uh oh!

azure-pipelines bot commented Oct 30, 2023

Uh oh!

khmakoto commented Oct 30, 2023

Uh oh!

azure-pipelines bot commented Oct 30, 2023

Uh oh!

khmakoto commented Oct 31, 2023

Uh oh!

azure-pipelines bot commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix typo in `specs/Datepicker.md` #29656

fix typo in `specs/Datepicker.md` #29656

codesandbox-ci bot commented Oct 26, 2023 •

edited

Loading

fabricteam commented Oct 30, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Oct 30, 2023 •

edited

Loading

fabricteam commented Oct 30, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Oct 30, 2023 •

edited

Loading

fabricteam commented Oct 30, 2023 •

edited

Loading

size-auditor bot commented Oct 30, 2023 •

edited

Loading

fabricteam commented Oct 30, 2023 •

edited

Loading

fabricteam commented Oct 30, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react`)