Skip to content

[WebNN] Support ConvInteger op #24803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guschmue merged 1 commit into from
May 19, 2025
Merged

[WebNN] Support ConvInteger op #24803

guschmue merged 1 commit into from
May 19, 2025

Conversation

@Honry
Copy link
Contributor

@Honry Honry commented May 19, 2025

WebNN doesn't provide a dedicated op for ConvInteger, this PR supports ConvInteger op by decomposing it into DequantizeLinear x, w -> Conv -> Cast (to int32).

BTW, adds ConvInteger to layout sensitive op list for layout transformation when the preferred layout is NHWC.

@Honry
[WebNN] Support ConvInteger op
ea82a12 
WebNN doesn't provide a dedicated op for ConvInteger,
this PR supports ConvInteger op by decomposing it into
DequantizeLinear x, w -> Conv -> Cast (to int32).

BTW, adds ConvInteger to layout sensitive op list for
layout transformation when the preferred layout is NHWC.
@Honry
Copy link
Contributor Author

Honry commented May 19, 2025

@fdwr, @guschmue, PTAL, thanks!

fdwr
fdwr approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr
Copy link
Contributor

fdwr commented May 19, 2025

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline,Windows GPU WebGPU CI Pipeline,Windows OpenVINO CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented May 19, 2025

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented May 19, 2025

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI

@fdwr
Copy link
Contributor

fdwr commented May 19, 2025

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines
Copy link

azure-pipelines bot commented May 19, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented May 19, 2025

Azure Pipelines successfully started running 2 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

azure-pipelines bot commented May 19, 2025

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented May 19, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue guschmue merged commit 5c97cb1 into microsoft:main May 19, 2025
82 checks passed
quic-ankus pushed a commit to CodeLinaro/onnxruntime that referenced this pull request Nov 25, 2025
@Honry @qti-hungjuiw
[WebNN] Support ConvInteger op (microsoft#24803)
77f92b5 
WebNN doesn't provide a dedicated op for `ConvInteger`, this PR supports
`ConvInteger` op by decomposing it into `DequantizeLinear x, w -> Conv
-> Cast (to int32)`.

BTW, adds `ConvInteger` to layout sensitive op list for layout
transformation when the preferred layout is NHWC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fdwr fdwr fdwr approved these changes

@guschmue guschmue guschmue approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Honry @fdwr @guschmue