Skip to content

SQL-2463: update release instructions #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
terakilobyte merged 8 commits into from
Nov 18, 2024
Merged

SQL-2463: update release instructions #304

terakilobyte merged 8 commits into from
Nov 18, 2024

Conversation

@terakilobyte
Copy link
Member

@terakilobyte terakilobyte commented Nov 13, 2024

No description provided.

@terakilobyte terakilobyte changed the base branch from master to on-prem-eap November 13, 2024 16:37
bucaojit
bucaojit reviewed Nov 13, 2024
View reviewed changes
RELEASE.md Outdated

#### Create the tag and push

To determine which version of [`libmongosqltranslate`](https://github.com/10gen/mongosql-rs) to build with the release, the version
Copy link
Member

@bucaojit bucaojit Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The wording here sounds like I need to determine something where it's really means to specify the version for evergreen to download and include. Not sure the best way to reword it but here's a suggestion:

To specify which version of libmongosqltranslate that should be built with the release, include the version of libmongosqltranslate in the tag name. This is done by annotating the tag with libv.

bucaojit
bucaojit approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@bucaojit bucaojit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nbagnard
nbagnard approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@nbagnard nbagnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I have 1 suggestions and 1 small request. If you can/want to update before pushing.

RELEASE.md Outdated
Among all the version standards Maven supports, we will use MajorVersion, IncrementalVersion and Qualifier inside this project.

The current version number is specified inside `gradle.properties` file.
The current version number is specified inside `gradle.properties` file.
Copy link
Collaborator

@nbagnard nbagnard Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not true (anymore). Could you remove or update that line.
We calculate and set the version via the gradle script based on the git version.

RELEASE.md Outdated
Create an annotated tag and push it (using the correct versions):

```sh
# git tag -a -m X.Y.Z-alpha-1-libvX.Y.Z-alpha vX.Y.Z-alpha-1-libvX.Y.Z-alpha
Copy link
Collaborator

@nbagnard nbagnard Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# git tag -a -m X.Y.Z-alpha-1-libvX.Y.Z-alpha vX.Y.Z-alpha-1-libvX.Y.Z-alpha
#git tag -a -m X.Y.Z[-<JDBCprerelease>]-libvXX.YY.ZZ[-<prerelease>]
For example :

@terakilobyte terakilobyte added this pull request to the merge queue Nov 18, 2024
Merged via the queue into mongodb:on-prem-eap with commit 626eb84 Nov 18, 2024
6 checks passed
@terakilobyte terakilobyte deleted the SQL-2463 branch November 18, 2024 22:17
bucaojit pushed a commit to bucaojit/mongo-jdbc-driver that referenced this pull request Apr 1, 2025
@terakilobyte @bucaojit
SQL-2463: update release instructions (mongodb#304)
51e7c97 
* SQL-2463: update release instructions

* change pr base

* remove files

* add quotes

* wording change

* clarify tags

* clarify versioning

* clarifications
github-merge-queue bot pushed a commit that referenced this pull request May 7, 2025
@bucaojit @jchemburkar
@mattChiaravalloti @nbagnard @pmeredit @EthanHardyMongo @terakilobyte
SQL-2544: Merge on-prem-eap branch into master (#337)
bc022ce 
* SQL-2397: evergreen updates (#289)

* add eap to jar names; disable publishing to maven

* fix s3 puts

* remove silk

* update bucket name

* cleanup evg  file

* cleanup pt2

* remove final bucket ref

* feedback

* SQL-2380: Download and build jars with translation libraries included (#288)

* SQL-2380: Initial evergreen attempt to fetch library files

* SQL-2380: Do not use variables

* SQL-2380: Fix variables

* SQL-2380: Update build task to fetch all libraries

* SQL-2380: Special case windows for now

* SQL-2380: Remove debug code

* SQL-2380: Debug code to check that files are included in jar

* SQL-2380: Clean up debug code

* SQL-2380: Restore unintended change

* SQL-2380: Parse lib version from tag and use that for fetching

* SQL-2380: Fix typo

* SQL-2380: Properly export new variable

* Update .evg.yml

Co-authored-by: Natacha Bagnard <[email protected]>

* Update .evg.yml

Co-authored-by: Patrick Meredith <[email protected]>

---------

Co-authored-by: Natacha Bagnard <[email protected]>
Co-authored-by: Patrick Meredith <[email protected]>

* SQL-2288 : Integration tests and loading library from inside the driver  (#290)

* Add integration tests

* Load library based on JVMplatform/os info
---------

Co-authored-by: Oliver Bucaojit <[email protected]>

* remove fetch mongosqltranslate windows

* Revert "remove fetch mongosqltranslate windows"

This reverts commit d3d606c.

* SQL-2406: Update fetch libmongosqltranslate windows to reuse generic fetch function in JDBC (#291)

* remove fetch mongosqltranslate windows

* rename windows folder to be consistent with evergreen

* SQL-2427: Add release tasks (#293)

* Release artifacts to translators-connectors-releases/eap/mongo-jdbc-driver-eap/
Co-authored-by: Oliver Bucaojit <[email protected]>

* SQL-2433: Update logic to extract versions (#295)

* Update logic to extract versions

* Use correct input

Co-authored-by: Oliver Bucaojit <[email protected]>

---------

Co-authored-by: Oliver Bucaojit <[email protected]>

* SQL-2385: JDBC documentation (#292)

* SQL-2385: JDBC documentation

* feedback and formatting

* SQL-2437:  Set release version (#298)

* Use property to flag tag triggered releases

* Simplify logic

* Fix typ

* Adding useful build logs

* SQL-2387: upload jdbc docs (#296)

* SQL-2387: upload jdbc docs

* udpate name

* SQL-2423: correctly report db version (#300)

* SQL-2423: correctly report db version

* test length

* spotless

* rework to be more streamlined

* SQL-2423: update logic

* spotless

* add logging

* reset libmongosqltranslate

* refactor

* add comment

* spotless

* SQL-2467: ensure proper db is used for queries (#305)

* SQL-2461: Add getCursorName (#302)

* SQL-2461: Add getCursorName

* SQL-2461: Add getCursorName

* SQL-2461: Add getCursorName

* SQL-2436: Split variables intialization for JDBC (#303)

* SQL-2436: Split variables intialization for JDBC

* SQL-2436: Move SSDLC variables to first logging command

* SQL-2460: Add handling for non-integer indexes (#301)

* add handling for non-integer indexes

* change null to empty string

* add filter to stream to remove non-integer indexes

* add boolean valueType to sortableBsonDoc

* SQL-2463: update release instructions (#304)

* SQL-2463: update release instructions

* change pr base

* remove files

* add quotes

* wording change

* clarify tags

* clarify versioning

* clarifications

* Update Smoketest logic to get jar previously built and not rebuild it (#308)

* SQL-2485: Augment original uri for specific auth mech (#310)

* Augment original uri for specific auth mech

* remove redundant comments

* Throw instead of returning Null when the augment the uri won't work

* Don't forget to wrap the exception in a SQLException

* Spotless

* SQL-2534: Add THIRDPARTY-LICENSE notice (#324)

* Add THIRDPARTY-LICENSE notice

* Clean-up

* SQL-2682: Pull mongosqltranslate library from Gradle script (#335)

* SQL-2544: Changes for direct cluster integration tests

* SQL-2544: Update dc integration test creds

* SQL-2544: Fix smoke test for eap and standard build

* SQL-2544: Add conditional logic for eap and non-eap builds

* SQL-2544: Fix incorrect eap check in integration test

* SQL-2544: Fix smoketest for eap build for manual test with env var

* SQL-2544: Address review comments

* SQL-2544: Fix mongosql library load test

* SQL-2544: spotlessApply

* SQL-2544: Update version with eap and snapshot

* SQL-2544: Re-add jar renaming

* Doc update (#349)

* chore: update overview to include new unwind syntax

* jdbc

* SQL-2822: update mongodb driver to automatically fetch newest version >= 5 and < 6 (#350)

---------

Co-authored-by: Jonathan Chemburkar <[email protected]>
Co-authored-by: Matthew Chiaravalloti <[email protected]>
Co-authored-by: Natacha Bagnard <[email protected]>
Co-authored-by: Patrick Meredith <[email protected]>
Co-authored-by: Ethan Hardy <[email protected]>
Co-authored-by: EthanHardyMongo <[email protected]>
Co-authored-by: Nathan Leniz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bucaojit bucaojit bucaojit approved these changes

@nbagnard nbagnard nbagnard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@terakilobyte @bucaojit @nbagnard