Use of Try-With-Resources #14583

alexknop · 2025-02-24T19:52:01Z

Problem:

Manual cleanup code is used for resources that can be automatically managed.

Solution:

Use of Try-With-Resources to enhance the overall stability, performance, and clarity of code, ensuring better resource management and minimizing potential issues related to improper resource handling.

github-actions · 2025-03-11T02:01:50Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

tobiasKaminsky · 2025-05-28T08:00:27Z

Pending manual tests

upload
upload via copy from another app to NC files ("upload content from apps").

alperozturk96

Hello

Thank you for the PR.

I'm currently experiencing an issue when attempting to upload files from other apps to the Nextcloud Files app.

Steps to Reproduce:

Navigate to a folder in the app.
Tap the "+" button at the bottom right.
Select "Upload content from other apps".

E  Could not find source file content://com.android.externalstorage.documents/document/primary%3ADownload%2Ftea%2F0003.webp
   java.io.FileNotFoundException: /storage/emulated/0/Android/media/com.nextcloud.client/nextcloud/tmp/[email protected]%3A55001/b4/0003.webp: open failed: ENOENT (No such file or directory)
   ...
Caused by: android.system.ErrnoException: open failed: ENOENT (No such file or directory)

alexknop · 2025-05-28T22:24:17Z

Hello

Thank you for the PR.

I'm currently experiencing an issue when attempting to upload files from other apps to the Nextcloud Files app.

Steps to Reproduce:

1. Navigate to a folder in the app.

2. Tap the "+" button at the bottom right.

3. Select "Upload content from other apps".

E  Could not find source file content://com.android.externalstorage.documents/document/primary%3ADownload%2Ftea%2F0003.webp
   java.io.FileNotFoundException: /storage/emulated/0/Android/media/com.nextcloud.client/nextcloud/tmp/[email protected]%3A55001/b4/0003.webp: open failed: ENOENT (No such file or directory)
   ...
Caused by: android.system.ErrnoException: open failed: ENOENT (No such file or directory)

I am trying this myself and cannot reproduce it. It looks like you were attempting a .webp file from your Documents folder? Do you have a full trace of this error? I'd like to see where it could be breaking, but I'm assuming it's something in the normalUpload function....

alperozturk96 · 2025-05-30T07:20:56Z

Hello
Thank you for the PR.
I'm currently experiencing an issue when attempting to upload files from other apps to the Nextcloud Files app.
Steps to Reproduce:
1. Navigate to a folder in the app.

2. Tap the "+" button at the bottom right.

3. Select "Upload content from other apps".
E  Could not find source file content://com.android.externalstorage.documents/document/primary%3ADownload%2Ftea%2F0003.webp
   java.io.FileNotFoundException: /storage/emulated/0/Android/media/com.nextcloud.client/nextcloud/tmp/[email protected]%3A55001/b4/0003.webp: open failed: ENOENT (No such file or directory)
   ...
Caused by: android.system.ErrnoException: open failed: ENOENT (No such file or directory)
I am trying this myself and cannot reproduce it. It looks like you were attempting a .webp file from your Documents folder? Do you have a full trace of this error? I'd like to see where it could be breaking, but I'm assuming it's something in the normalUpload function....

E  Could not find source file content://com.android.externalstorage.documents/document/primary%3ADownload%2Fend%2F0028.webp  
   java.io.FileNotFoundException: 
   /storage/emulated/0/Android/media/com.nextcloud.client/nextcloud/tmp/[email protected]/abc/0028.webp: 
   open failed: ENOENT (No such file or directory)

    at libcore.io.IoBridge.open(IoBridge.java:574)
    at java.io.FileOutputStream.<init>(FileOutputStream.java:259)
    at java.io.FileOutputStream.<init>(FileOutputStream.java:147)
    at com.owncloud.android.ui.asynctasks.CopyAndUploadContentUrisTask.doInBackground(CopyAndUploadContentUrisTask.java:149)
    at com.owncloud.android.ui.asynctasks.CopyAndUploadContentUrisTask.doInBackground(CopyAndUploadContentUrisTask.java:41)
    at android.os.AsyncTask$3.call(AsyncTask.java:394)
    at java.util.concurrent.FutureTask.run(FutureTask.java:317)
    at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:305)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1156)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:651)
    at java.lang.Thread.run(Thread.java:1119)

Caused by: android.system.ErrnoException: open failed: ENOENT (No such file or directory)

    at libcore.io.Linux.open(Native Method)
    at libcore.io.ForwardingOs.open(ForwardingOs.java:568)
    at libcore.io.BlockGuardOs.open(BlockGuardOs.java:274)
    at libcore.io.ForwardingOs.open(ForwardingOs.java:568)
    at android.app.ActivityThread$AndroidOs.open(ActivityThread.java:8953)
    at libcore.io.IoBridge.open(IoBridge.java:560)
    at java.io.FileOutputStream.<init>(FileOutputStream.java:259)
    at java.io.FileOutputStream.<init>(FileOutputStream.java:147)
    at com.owncloud.android.ui.asynctasks.CopyAndUploadContentUrisTask.doInBackground(CopyAndUploadContentUrisTask.java:149)
    at com.owncloud.android.ui.asynctasks.CopyAndUploadContentUrisTask.doInBackground(CopyAndUploadContentUrisTask.java:41)
    at android.os.AsyncTask$3.call(AsyncTask.java:394)
    at java.util.concurrent.FutureTask.run(FutureTask.java:317)
    at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:305)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1156)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:651)
    at java.lang.Thread.run(Thread.java:1119)

Here is the demo. Thank you.

dm.mp4

Signed-off-by: Alex Knop <[email protected]>

alexknop · 2025-05-30T20:58:28Z

@alperozturk96 I believe I fixed it. I had accidentally moved some commands into the try loop which were originally called before creating the FileOutputStream. This should now be synonymous with how the code was before.

github-actions · 2025-05-30T21:06:24Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14583.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions · 2025-05-30T21:07:55Z

Codacy

Lint

Type	master	PR
Warnings	51	51
Errors	11	11

SpotBugs

Category	Base	New
Bad practice	65	65
Correctness	58	60
Dodgy code	292	282
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	1	1
Multithreaded correctness	7	7
Performance	51	49
Security	18	18
Total	500	490

alperozturk96

Tested, works as expected.

alexknop force-pushed the tryResources branch from a2b706e to 416c810 Compare February 24, 2025 20:05

AndyScherzinger requested review from alperozturk96 and tobiasKaminsky February 25, 2025 10:02

AndyScherzinger added 3. to review technical debt labels Feb 25, 2025

AndyScherzinger requested a review from ZetaTom March 9, 2025 19:14

github-actions bot added the feedback-requested label Mar 11, 2025

alperozturk96 force-pushed the tryResources branch from ce20873 to c93aa98 Compare March 11, 2025 09:45

alexknop force-pushed the tryResources branch from c93aa98 to 1939237 Compare March 27, 2025 19:28

alexknop force-pushed the tryResources branch from 1939237 to d4aba9d Compare April 22, 2025 14:54

alperozturk96 force-pushed the tryResources branch from d4aba9d to fbbb777 Compare April 25, 2025 14:07

alexknop force-pushed the tryResources branch 2 times, most recently from d850f42 to c4d4e0a Compare April 30, 2025 15:59

alexknop force-pushed the tryResources branch 2 times, most recently from 2d1225a to d06522d Compare May 18, 2025 00:28

alperozturk96 requested changes May 28, 2025

View reviewed changes

alexknop force-pushed the tryResources branch 2 times, most recently from fd030c4 to d9f273a Compare May 28, 2025 22:24

use TryResources

e6f38a9

Signed-off-by: Alex Knop <[email protected]>

alexknop force-pushed the tryResources branch from d9f273a to e6f38a9 Compare May 30, 2025 20:55

alperozturk96 approved these changes Jun 2, 2025

View reviewed changes

AndyScherzinger enabled auto-merge June 11, 2025 21:26

AndyScherzinger approved these changes Jun 11, 2025

View reviewed changes

AndyScherzinger merged commit fa83d67 into master Jun 12, 2025
20 of 21 checks passed

AndyScherzinger deleted the tryResources branch June 12, 2025 09:02

AndyScherzinger added this to the Nextcloud App 3.32.0 milestone Jun 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Use of Try-With-Resources #14583

Use of Try-With-Resources #14583

Uh oh!

alexknop commented Feb 24, 2025

Uh oh!

github-actions bot commented Mar 11, 2025

Uh oh!

tobiasKaminsky commented May 28, 2025

Uh oh!

alperozturk96 left a comment

Uh oh!

alexknop commented May 28, 2025

Uh oh!

alperozturk96 commented May 30, 2025

Uh oh!

alexknop commented May 30, 2025

Uh oh!

github-actions bot commented May 30, 2025

Uh oh!

github-actions bot commented May 30, 2025

Uh oh!

alperozturk96 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Use of Try-With-Resources #14583

Use of Try-With-Resources #14583

Uh oh!

Conversation

alexknop commented Feb 24, 2025

Uh oh!

github-actions bot commented Mar 11, 2025

Uh oh!

tobiasKaminsky commented May 28, 2025

Uh oh!

alperozturk96 left a comment

Choose a reason for hiding this comment

Uh oh!

alexknop commented May 28, 2025

Uh oh!

alperozturk96 commented May 30, 2025

Uh oh!

alexknop commented May 30, 2025

Uh oh!

github-actions bot commented May 30, 2025

Uh oh!

github-actions bot commented May 30, 2025

Codacy

Lint

SpotBugs

Uh oh!

alperozturk96 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants