Skip to content

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Apr 16, 2025

  • Tests written, or not not needed

How to Reproduce

  1. Create an encrypted folder.
  2. Try to upload an image.
  3. Observe the log — you will see a "Failed to unlock file with path" error.

Fix

UploadFileOperation com.nextcloud.client: Failed to unlock file with path /data/user/0/com.nextcloud.client/files/nextcloud/tmp/[email protected]%3A55002/abc/0008.webp

Changes

  • Uses ApacheUtils for copying the file.
  • Stops relying on RemoteOperationResult for the copy operation.

Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the bugfix/e2ee-copy-lock-unlock-file branch from 5757fea to 20883cd Compare April 16, 2025 13:47
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5454
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6564
Correctness5858
Dodgy code292290
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5147
Security1818
Total500493

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14800.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96
Copy link
Collaborator Author

Outdated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants