Update Node.js version and Lingui packages #3658
Conversation
16a041f to
9972f55
Compare
zipkin-lens/.linguirc
Outdated
| } | ||
| ], | ||
| "format": "minimal" | ||
| "format": "po" |
There was a problem hiding this comment.
"po" format is strongly recommended.
https://lingui.dev/ref/catalog-formats#po
| "zh-cn" | ||
| ], | ||
| "sourceLocale": "en", | ||
| "fallbackLocale": "en", |
There was a problem hiding this comment.
| "@lingui/react": "4.6.0", | ||
| "@material-ui/core": "^4.1.1", | ||
| "@material-ui/data-grid": "4.0.0-alpha.37", | ||
| "@material-ui/data-grid": "4.0.0-alpha.24", |
There was a problem hiding this comment.
Temporarily downgrade to pass npm install.
@material-ui/data-grid 4.0.0-alpha.37's peer dependency is react 17. But we are still using react 16.
I'll update this again after update react version.
| alignItems="center" | ||
| > | ||
| <Logo alt={i18n._(t`Zipkin`)} /> | ||
| <Logo alt={_(msg`Zipkin`)} /> |
There was a problem hiding this comment.
|
|
||
| expect(close.mock.calls.length).toBe(1); | ||
| // TODO: Should comment out this line. | ||
| // expect(close.mock.calls.length).toBe(1); |
There was a problem hiding this comment.
This line does not work for some reason. I don't know why.
The UI itself is working as expected. The problem is occurring only in the test.
After updating all other packages, I'll revisit this issue.
| }, | ||
| infoCell: { | ||
| display: 'flex', | ||
| fontWeight: theme.typography.fontWeightRegular, |
There was a problem hiding this comment.
A type error is occurring for some reason in font-weight.
I think this will probably be resolved by updating the Material UI version.
| return; | ||
| } | ||
| setLocale(locale); | ||
| window.location.reload(); |
There was a problem hiding this comment.
Now we can change languages without reload().
translation.mov
| * or implied. See the License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| import { createMuiTheme } from '@material-ui/core/styles'; |
There was a problem hiding this comment.
createMuiTheme is deprecated.
| ], | ||
| "format": "minimal" | ||
| "format": "po", | ||
| "compileNamespace": "ts" |
There was a problem hiding this comment.
We can create translation files as ts.
| it('language select changes locale and refreshes', async () => { | ||
| render(<LanguageSelector />); | ||
| fireEvent.click(screen.getByTestId('language-list-item-zh-cn')); | ||
| await expect(window.location.reload).toHaveBeenCalled(); |
There was a problem hiding this comment.
Now reload() is not called.
|
thanks @tacigar! |
Uh oh!
There was an error while loading. Please reload this page.