fix(TTML): Fix support of urls in smpte:backgroundImage #5851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Incremental code coverage: 100.00% |
theodab
suggested changes
Nov 5, 2023
Contributor
theodab
left a comment
There was a problem hiding this comment.
I feel like the name of this PR is inaccurate.
I'm not an expert on TTML or anything, but looking at the code we already do support smpte:backgroundImage. We just support a different use-case of it than the one this PR adds, right?
theodab
approved these changes
Nov 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5049