chore: Fix deprecation messages #6289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some deprecation messages were misleading, and claimed that entire
classes like AbrManager were deprected, when in fact, it was a
particular form of AbrManager (without a method) that is deprecated.
This adds method and other details to the deprecation calls where
needed.
We also had a malformed messsage where join('') was called on the
pieces instead of join(' '). This fixes the formatting.
alekzz
approved these changes
Feb 23, 2024
Collaborator
|
Incremental code coverage: 33.33% |
joeyparrish
added a commit
that referenced
this pull request
Feb 26, 2024
Some deprecation messages were misleading, and claimed that entire
classes like AbrManager were deprected, when in fact, it was a
particular form of AbrManager (without a method) that is deprecated.
This adds method and other details to the deprecation calls where
needed.
We also had a malformed messsage where join('') was called on the pieces
instead of join(' '). This fixes the formatting.
Backported to v4.7.x
joeyparrish
added a commit
that referenced
this pull request
Feb 26, 2024
Some deprecation messages were misleading, and claimed that entire
classes like AbrManager were deprected, when in fact, it was a
particular form of AbrManager (without a method) that is deprecated.
This adds method and other details to the deprecation calls where
needed.
We also had a malformed messsage where join('') was called on the pieces
instead of join(' '). This fixes the formatting.
Backported to v4.6.x
joeyparrish
added a commit
that referenced
this pull request
Feb 27, 2024
Some deprecation messages were misleading, and claimed that entire
classes like AbrManager were deprected, when in fact, it was a
particular form of AbrManager (without a method) that is deprecated.
This adds method and other details to the deprecation calls where
needed.
We also had a malformed messsage where join('') was called on the pieces
instead of join(' '). This fixes the formatting.
Backported to v4.3.x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some deprecation messages were misleading, and claimed that entire classes like AbrManager were deprected, when in fact, it was a particular form of AbrManager (without a method) that is deprecated.
This adds method and other details to the deprecation calls where needed.
We also had a malformed messsage where join('') was called on the pieces instead of join(' '). This fixes the formatting.